[MIRROR] Fixes #916 and #980 (Missing icon overlay on circuit multitool) #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iajret
pushed a commit
that referenced
this pull request
Apr 16, 2024
* First test Zydra suspected this might be it but who knows * Might as well fix this CI dunno where it came frome * this probally too * for sure fix that CI * Undo this, it didnt fix it * for the time being seeing if this passes CI * CI's Fully Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#983
About The Pull Request
I thought this was from my tool cleanup, hence the branch name... but this technically ISN'T actually my fault! The original modular file was missing this overlay icon too!
We just never knew because it's a single pixel that's only overlayed in a specific case on this specific unused tool. So.
How This Contributes To The Nova Sector Roleplay Experience
Bug fix of a flaky test run.
Fixes #916
Fixes #980
Proof of Testing
It's a single pixel so I genuinely can't show you if it worked or not since it's too small...
But the icon is now in the file the icon was meant to be in, and the .dme built.
Changelog
No player-facing changes.