Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes Cargo Lockbox Iconstates #2001

Merged
merged 1 commit into from
Feb 17, 2024
Merged

[MIRROR] Fixes Cargo Lockbox Iconstates #2001

merged 1 commit into from
Feb 17, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#984
Original PR: tgstation/tgstation#81481

About The Pull Request

The cargo lockboxes didn't update iconstates when locked. Seems like an oversight given that their parent object does this and there's unused sprites for this behaviour in this item, so this enables it to use those sprites that are already in code.

Why It's Good For The Game

It's hard to know if someone has taken their items or not because an unlocked case looks identical to a locked one. Also fixes an oversight idk.

Changelog

🆑 Sylphet
fix: cargo lockboxes update iconstates correctly now
/:cl:

* Fixes Cargo Lockbox Iconstates (#81481)

## About The Pull Request

The cargo lockboxes didn't update iconstates when locked. Seems like an
oversight given that their parent object does this and there's unused
sprites for this behaviour in this item, so this enables it to use those
sprites that are already in code.

## Why It's Good For The Game

It's hard to know if someone has taken their items or not because an
unlocked case looks identical to a locked one. Also fixes an oversight
idk.

## Changelog
:cl:
fix: cargo lockboxes update iconstates correctly now
/:cl:

* Fixes Cargo Lockbox Iconstates

---------

Co-authored-by: Sylphet <[email protected]>
@Iajret Iajret merged commit cde007b into master Feb 17, 2024
24 checks passed
AnywayFarus added a commit that referenced this pull request Feb 17, 2024
@Iajret Iajret deleted the upstream-mirror-984 branch February 17, 2024 16:21
Iajret pushed a commit that referenced this pull request Apr 16, 2024
* Hey what if admins were allowed to use the player panel (#82682)

Re-adds the player panel verb to the verb panel.

* Hey what if admins were allowed to use the player panel

---------

Co-authored-by: Zephyr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants