[MIRROR] [MODULAR] Fixes a runtime in engaged_role_play_check #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a runtime in engaged_role_play_check * Inverts the return value * Update ev_roleplay_check.dm * Update ev_roleplay_check.dm
Iajret
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Birdshot Wall Sanity Pass (#82598) ## About The Pull Request Cleans up minor artifacting in the Birdshot Sec-Tram Closed Turfs ## Why It's Good For The Game Someone definitely didn't mean to place some machines under Closed Turfs. This barely qualifies as player facing. ## Changelog :cl: fix: Cleans up some rocks on Birdshot /:cl: * Birdshot Wall Sanity Pass --------- Co-authored-by: Zytolg <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Birdshot Wall Sanity Pass (#82598) ## About The Pull Request Cleans up minor artifacting in the Birdshot Sec-Tram Closed Turfs ## Why It's Good For The Game Someone definitely didn't mean to place some machines under Closed Turfs. This barely qualifies as player facing. ## Changelog :cl: fix: Cleans up some rocks on Birdshot /:cl: * Birdshot Wall Sanity Pass --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Zytolg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#970
About The Pull Request
Fixes the following runtime:
Also inverts the return value for the
engaged_role_play_check()proc because it makes more sense that way when reading it. (TRUE = player is engaged, FALSE = player is in dorms/off station/unengaged)How This Contributes To The Nova Sector Roleplay Experience
Changelog
Nothing player facing really