[MIRROR] Fixes product_categories not working for non-constructable vending machines.
#2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vending machines. (#1007) * Fixes `product_categories` not working for non-constructable vending machines. (#81467) ## About The Pull Request This is something I've discovered while working on the previous PR. ## Why It's Good For The Game Prevents future issues with non-constructable vending machines that use categories, since we don't have any such thing rn. ## Changelog N/A * Fixes `product_categories` not working for non-constructable vending machines. --------- Co-authored-by: Ghom <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 16, 2024
…ecial case (#2020) * [NO GBP] Fixes deconstruction of closets & crates under a special case (#82612) ## About The Pull Request So if a closet/crate has the `NO_DEBRIS_AFTER_DECONSTRUCTION` set on it and if someone/something is still inside, then after deconstruction they get deleted rather than getting dumped out first. Could cause potential hard delete of mobs & stuff. We don't want to deal with that ## Changelog :cl: fix: closets & crates will dump all contents out first before deleting itself regardless of `NO_DEBRIS_AFTER_DECONSTRUCTION` thus not for e.g. hard deleting mobs inside it /:cl: * [NO GBP] Fixes deconstruction of closets & crates under a special case --------- Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1007
Original PR: tgstation/tgstation#81467
About The Pull Request
This is something I've discovered while working on the previous PR.
Why It's Good For The Game
Prevents future issues with non-constructable vending machines that use categories, since we don't have any such thing rn.
Changelog
N/A