[MIRROR] Adds a proper skeletal rack subtype #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a proper skeletal rack subtype (#81484) ## About The Pull Request This is mapped in a few places and I thought it would be better to have a subtype of rack to use rather than varediting the icon and state. ## Why It's Good For The Game The less varedited icons the better imo, it's way easier to ensure icons aren't fucked up this way and easier to fix too. ## Changelog No player-facing changes. * Adds a proper skeletal rack subtype --------- Co-authored-by: John Willard <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 17, 2024
…l on attacking non-mobs (2 year old bug) (#2030) * Yeets `ATTACK_QDELETED`, fixes welding torches not using fuel on attacking non-mobs (2 year old bug) (#82694) ## About The Pull Request - Deletes `ATTACK_QDELETED` - May have been necessary in the past but it's pointless now. All it does is clutter the attack chain. Perish. - Fixes welders not using fuel on attacking non-mobs - #65762 "fixed" welders consuming fuel on clicking turfs by adding an `isliving` check and not an `ismovable` check? ## Changelog :cl: Melbert fix: Blobs may rejoice, welding torches now consume fuel when attacking objects again after two years. /:cl: * Yeets `ATTACK_QDELETED`, fixes welding torches not using fuel on attacking non-mobs (2 year old bug) * Electric welders are hot too now. Starting fires is definitely in their wheelhouse --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1012
Original PR: tgstation/tgstation#81484
About The Pull Request
This is mapped in a few places and I thought it would be better to have a subtype of rack to use rather than varediting the icon and state.
Why It's Good For The Game
The less varedited icons the better imo, it's way easier to ensure icons aren't fucked up this way and easier to fix too.
Changelog
No player-facing changes.