Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Traitor Traitor Panel Fixes #2036

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[MIRROR] Traitor Traitor Panel Fixes #2036

merged 1 commit into from
Feb 19, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1029
Original PR: tgstation/tgstation#81521

About The Pull Request

  • Fixes #81514

    • Setting TC checked for value && isnum(value) which was dumb when value could be 0.
  • Removing Traitor auto-takes uplink from the mob

  • Removing Uplink now removes just the uplink code from memory, rather than all memories

Changelog

🆑 Melbert
admin: You can now set someone's TC to 0
admin: Removing Traitor from automatically removes the uplink from them
admin: Removing Uplink from someone no longer wipes ALL of their memories
/:cl:

* Traitor Traitor Panel Fixes (#81521)

## About The Pull Request

- Fixes #81514
- Setting TC checked for `value && isnum(value)` which was dumb when
`value` could be `0`.

- Removing Traitor auto-takes uplink from the mob 

- Removing Uplink now removes just the uplink code from memory, rather
than all memories

## Changelog

:cl: Melbert
admin: You can now set someone's TC to 0
admin: Removing Traitor from automatically removes the uplink from them 
admin: Removing Uplink from someone no longer wipes ALL of their
memories
/:cl:

* Traitor Traitor Panel Fixes

---------

Co-authored-by: MrMelbert <[email protected]>
@Iajret Iajret merged commit 60e9a39 into master Feb 19, 2024
24 checks passed
AnywayFarus added a commit that referenced this pull request Feb 19, 2024
@Iajret Iajret deleted the upstream-mirror-1029 branch February 20, 2024 09:25
Iajret pushed a commit that referenced this pull request Apr 18, 2024
* grappling gun (#82209)

## About The Pull Request
adds a new weapon to mining, the grapple gun. this weapon is a new fun
way to traverse lavaland, it lets u grapple onto things and ziplines u
towards them.


https://github.com/tgstation/tgstation/assets/138636438/5e935776-1482-4994-bcc7-e1ca7fcf33dc

while its less practical than things like the spinning mining modsuit
module, or xenobio wings, its still very fun to use.
u can also use this as a weapon against mobs! (like batman) 

the zipline will launch u towards the mob, doing some damage to them and
launching them back


https://github.com/tgstation/tgstation/assets/138636438/3bf77fe5-4ed1-4153-8673-a0786ecee98f

## Why It's Good For The Game
adds a new fun harmless way to travel through mining biomes 

## Changelog
:cl:
add: miners can now purchase grapple guns
/:cl:

* grappling gun

---------

Co-authored-by: Ben10Omintrix <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 18, 2024
* grappling gun (#82209)

## About The Pull Request
adds a new weapon to mining, the grapple gun. this weapon is a new fun
way to traverse lavaland, it lets u grapple onto things and ziplines u
towards them.


https://github.com/tgstation/tgstation/assets/138636438/5e935776-1482-4994-bcc7-e1ca7fcf33dc

while its less practical than things like the spinning mining modsuit
module, or xenobio wings, its still very fun to use.
u can also use this as a weapon against mobs! (like batman) 

the zipline will launch u towards the mob, doing some damage to them and
launching them back


https://github.com/tgstation/tgstation/assets/138636438/3bf77fe5-4ed1-4153-8673-a0786ecee98f

## Why It's Good For The Game
adds a new fun harmless way to travel through mining biomes 

## Changelog
:cl:
add: miners can now purchase grapple guns
/:cl:

* grappling gun

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Ben10Omintrix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants