[MIRROR] Fixes smoothing breaking if a map is loaded post init #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes smoothing breaking if a map is loaded post init (#81526) ## About The Pull Request We'd finish a set of atom creation, then try and smooth those atoms The problem is they might try and smooth with an uninitialized neighbor, which wouldn't have its smoothing vars parsed. This fixes that by pooling "to be smoothed" things into a list based off the source of the init stoppage, which we then release when we're done. Also fixes things staying in mapload, even during a sleep. This can cause massive headaches so it's good to avoid. This has a cost but it's minuscule (on the order of like 0.006s (6ms over all of init), so I'm happy with it. ## Why It's Good For The Game Closes #77040 ## Changelog :cl: fix: Maps loaded in after roundstart will no longer have broken smoothing /:cl: * Fixes smoothing breaking if a map is loaded post init --------- Co-authored-by: LemonInTheDark <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 19, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Removes avatar earpiece [no gbp] (#82609) ## About The Pull Request There's no comms in the digital plane anyway so this is only stopping them from exploiting binary comms ## Why It's Good For The Game Exploit fix Fixes #82604 ## Changelog :cl: fix: Bit avatars no longer have access to free binary comms with the AI outfit /:cl: * Removes avatar earpiece [no gbp] --------- Co-authored-by: Jeremiah <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Removes avatar earpiece [no gbp] (#82609) ## About The Pull Request There's no comms in the digital plane anyway so this is only stopping them from exploiting binary comms ## Why It's Good For The Game Exploit fix Fixes #82604 ## Changelog :cl: fix: Bit avatars no longer have access to free binary comms with the AI outfit /:cl: * Removes avatar earpiece [no gbp] --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Jeremiah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1021
Original PR: tgstation/tgstation#81526
About The Pull Request
We'd finish a set of atom creation, then try and smooth those atoms The problem is they might try and smooth with an uninitialized neighbor, which wouldn't have its smoothing vars parsed.
This fixes that by pooling "to be smoothed" things into a list based off the source of the init stoppage, which we then release when we're done.
Also fixes things staying in mapload, even during a sleep. This can cause massive headaches so it's good to avoid.
This has a cost but it's minuscule (on the order of like 0.006s (6ms over all of init), so I'm happy with it.
Why It's Good For The Game
Closes #77040
Changelog
🆑 LemonInTheDark
fix: Maps loaded in after roundstart will no longer have broken smoothing
/:cl: