Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix Ai tracking runtime #2041

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[MIRROR] Fix Ai tracking runtime #2041

merged 1 commit into from
Feb 19, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1026
Original PR: tgstation/tgstation#81518

About The Pull Request

First arg is tracker, second arg is name.

Changelog

🆑 Melbert
fix: Fixes AI double-click tracking
/:cl:

* Fix Ai tracking runtime (#81518)

## About The Pull Request

First arg is tracker, second arg is name. 

## Changelog

:cl: Melbert
fix: Fixes AI double-click tracking
/:cl:

* Fix Ai tracking runtime

---------

Co-authored-by: MrMelbert <[email protected]>
@Iajret Iajret merged commit 8038a98 into master Feb 19, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1026 branch February 19, 2024 17:56
AnywayFarus added a commit that referenced this pull request Feb 19, 2024
Iajret pushed a commit that referenced this pull request Apr 18, 2024
* Regal Rats can now tear down posters (#82673)

## About The Pull Request

i was fixing something on bagil and someone who was playing a regal rat
(after the round ended) said they wanted to be able to tear down posters
as a regal rat so i decided to code it because it made sense.

it's an element so literally any mob can tear down posters but i can't
think of any other mobs that would make sense to let it tear down
posters so we'll leave it just for _The Champion of All Mislaid
Creatures_ for now
## Why It's Good For The Game

Regal Rats should be all about sludgemaxxing and fucking up maintenance
to make it look even more grody than it should be. Being able to tear up
those disgusting and well-drawn posters to leave behind nothing but
scraps fits that motif. The element has a `do_after()` just to make sure
His Holiness doesn't accidentally tear down his posters while clicking
(i think all mobs should have this but that's a different issue man)

also includes some code improvement and user feedback in some failure
cases that already existed in the code.
## Changelog
:cl:
add: Regal Rats are now able to tear down those colorful posters those
weird grey creatures keep spackling up on the walls of their rightful
domain.
/:cl:

* Regal Rats can now tear down posters

---------

Co-authored-by: san7890 <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 18, 2024
* Regal Rats can now tear down posters (#82673)

## About The Pull Request

i was fixing something on bagil and someone who was playing a regal rat
(after the round ended) said they wanted to be able to tear down posters
as a regal rat so i decided to code it because it made sense.

it's an element so literally any mob can tear down posters but i can't
think of any other mobs that would make sense to let it tear down
posters so we'll leave it just for _The Champion of All Mislaid
Creatures_ for now
## Why It's Good For The Game

Regal Rats should be all about sludgemaxxing and fucking up maintenance
to make it look even more grody than it should be. Being able to tear up
those disgusting and well-drawn posters to leave behind nothing but
scraps fits that motif. The element has a `do_after()` just to make sure
His Holiness doesn't accidentally tear down his posters while clicking
(i think all mobs should have this but that's a different issue man)

also includes some code improvement and user feedback in some failure
cases that already existed in the code.
## Changelog
:cl:
add: Regal Rats are now able to tear down those colorful posters those
weird grey creatures keep spackling up on the walls of their rightful
domain.
/:cl:

* Regal Rats can now tear down posters

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: san7890 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants