[MIRROR] allows to reorder chat tabs & hides delete from main tab #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * allows to reorder chat tabs & hides delete from main tab (#81455) ## About The Pull Request This pull request aims to hide the delete button from the main chat tab as well as to allow reordering of the other chat tabs. ((Not to cause any issues with existing tabs, the variable has to be true, so the hiding of the delete button only takes effect for new players or when someone deleted all tabs once))   ## Why It's Good For The Game - I'm not quite sure, why the main tab has the delete button in the first place, after all, it's not like the tab should be removed? So, we can just hide the delete button on that tab and keep it always there. - Accidentally deleting a chat tab when one has multiple tabs set up requires to change all tabs to the right to regain the previous order, so why not simply allow to reorder all tabs except for the main tab. (The main tab can neither be moved, nor can anything swapped with it) ## Changelog :cl: qol: hides the delete button on the main tab allows to reorder all other chat tabs /:cl: * allows to reorder chat tabs & hides delete from main tab --------- Co-authored-by: Kashargul <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 19, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 19, 2024
Clocking out opens the job slot
ReezeBL
pushed a commit
that referenced
this pull request
Apr 19, 2024
Clocking out opens the job slot Co-authored-by: FlufflesTheDog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1042
Original PR: tgstation/tgstation#81455
About The Pull Request
This pull request aims to hide the delete button from the main chat tab as well as to allow reordering of the other chat tabs.
((Not to cause any issues with existing tabs, the variable has to be true, so the hiding of the delete button only takes effect for new players or when someone deleted all tabs once))
Why It's Good For The Game
So, we can just hide the delete button on that tab and keep it always there.
Changelog
🆑 Kashargul
qol: hides the delete button on the main tab allows to reorder all other chat tabs
/:cl: