[MIRROR] Alternate job titles (chef, department security) actually imprint this title onto your PDA #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…print this title onto your PDA (#1106) * Alternate job titles (chef, department security) actually imprint this title onto your PDA (#81602) * Alternate job titles (chef, department security) actually imprint this title onto your PDA --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 24, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1106
Original PR: tgstation/tgstation#81602
About The Pull Request
An issue I noticed while debugging chef not showing up on the crew monitor: while the security and cook jobs can have alternate ID trims with alternate job titles, they do not actually imprint this onto their PDAs.
This just makes the Cook job imprint their current ID onto the PDA in
post_equip, and Security Officer does so after applying the trim insetup_department(called inafter_roundstart_spawnandafter_latejoin_spawn).Why It's Good For The Game
Fixes the PDA to ID mismatch for alternate job titles for Cook and Security Office.
Changelog
🆑 00-Steven
fix: Chef and department security have the assignment on their ID imprinted onto their PDA by default, instead of defaulting to Cook/Security Officer and requiring you to do so manually.
/:cl: