[MIRROR] Fixes random CI error #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes random CI error (#81657) ## About The Pull Request Closes tgstation/tgstation#81329 Closes tgstation/tgstation#81538 I made some improvements to tactical and twohanded in general, but here's the fixes I made: - Two-handed now unregisters signals for fantasy bonuses - Tactical was registering signals for update icons, which in the case of kirbyplants was called every time the item was picked up due to two-handed's ``update_appearance`` call, so every time you picked up the plant it would actually register signals twice, applying overlays twice, etc. I removed the signal to update icon because it didn't really make sense, we update on equip/move/z move, which should be all the cases we need. For some reason someone made Monkeys able to hold two-handed items now, and it appears that in monkey business a monkey can try to pick up a kirby plant, causing this CI error to be sporadic. ## Why It's Good For The Game Fixes a CI error by removing a useless signal that was causing kirby plants to register a bunch of signals twice over every time you picked one up.  ## Changelog Nothing player facing. * Fixes random CI error --------- Co-authored-by: John Willard <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 22, 2024
…2128) * Allows vv investigate /appearance + better checking image (#82670) * Allows vv investigate /appearance + better checking image --------- Co-authored-by: EvilDragonfiend <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 22, 2024
…2128) (#3013) * Allows vv investigate /appearance + better checking image (#82670) * Allows vv investigate /appearance + better checking image --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: EvilDragonfiend <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1134
Original PR: tgstation/tgstation#81657
About The Pull Request
Closes tgstation/tgstation#81329
Closes tgstation/tgstation#81538
I made some improvements to tactical and twohanded in general, but here's the fixes I made:
update_appearancecall, so every time you picked up the plant it would actually register signals twice, applying overlays twice, etc. I removed the signal to update icon because it didn't really make sense, we update on equip/move/z move, which should be all the cases we need.For some reason someone made Monkeys able to hold two-handed items now, and it appears that in monkey business a monkey can try to pick up a kirby plant, causing this CI error to be sporadic.
Why It's Good For The Game
Fixes a CI error by removing a useless signal that was causing kirby plants to register a bunch of signals twice over every time you picked one up.
Changelog
Nothing player facing.