[MIRROR] Minor newscaster UI fix #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor newscaster UI fix (#81638) ## About The Pull Request Currently newscasters note "No wanted issue posted. Have a secure day." regardless of whether there's an active wanted issue posted or not. Looking into the code, `Newscaster.jsx` does actually detail an alternate message for when there _is_ an active wanted issue. It's just only active when `wanted.active` holds true, while I believe the `active` it's trying to access cannot be accessed without using `wanted.map(...)`. Making it use `wanted.map(...)` solves this. <details> <summary>Image</summary>  </details> ## Why It's Good For The Game Fixes #81600. ## Changelog :cl: fix: Newscasters no longer say "No wanted issue posted. Have a secure day." when there is, in fact, an active wanted issue currently posted. /:cl: * Minor newscaster UI fix --------- Co-authored-by: _0Steven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1149
Original PR: tgstation/tgstation#81638
About The Pull Request
Currently newscasters note "No wanted issue posted. Have a secure day." regardless of whether there's an active wanted issue posted or not.
Looking into the code,
Newscaster.jsxdoes actually detail an alternate message for when there is an active wanted issue. It's just only active whenwanted.activeholds true, while I believe theactiveit's trying to access cannot be accessed without usingwanted.map(...).Making it use
wanted.map(...)solves this.Image
Why It's Good For The Game
Fixes #81600.
Changelog
🆑 00-Steven
fix: Newscasters no longer say "No wanted issue posted. Have a secure day." when there is, in fact, an active wanted issue currently posted.
/:cl: