[MIRROR] Fix: AI Hologram Copying Station Members #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix: AI Hologram Copying Station Members (#81701) ## About The Pull Request This PR fixes a bug which disables the AI hologram's ability to copy the appearance of crew members. Fixes #78403 The bug was caused by developer error in PR #72725 when the typepath `/datum/record/crew` was used to access `GLOB.manifest.locked`, which is a list of `/datum/record/locked`. To fix the bug I replaced the erroneous typepath with `/datum/record/locked`. ## Why It's Good For The Game This PR fixes the broken feature that used to allow the AI to select from the crew records to set its hologram's appearance.   ## Changelog :cl: A.C.M.O. fix: Fixed the AI hologram's ability to copy the appearance of crew members. /:cl: * Fix: AI Hologram Copying Station Members --------- Co-authored-by: Dani Glore <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 29, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 24, 2024
* brimbeams are a hidden do after (#82856) * brimbeams are a hidden do after --------- Co-authored-by: Fikou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1186
Original PR: tgstation/tgstation#81701
About The Pull Request
This PR fixes a bug which disables the AI hologram's ability to copy the appearance of crew members. Fixes #78403
The bug was caused by developer error in PR #72725 when the typepath
/datum/record/crewwas used to accessGLOB.manifest.locked, which is a list of/datum/record/locked. To fix the bug I replaced the erroneous typepath with/datum/record/locked.Why It's Good For The Game
This PR fixes the broken feature that used to allow the AI to select from the crew records to set its hologram's appearance.
Changelog
🆑 A.C.M.O.
fix: Fixed the AI hologram's ability to copy the appearance of crew members.
/:cl: