[MIRROR] Fix early return in airlock engineering override #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move override early returns * fix CI on abductor airlock
Iajret
pushed a commit
that referenced
this pull request
Apr 28, 2024
* Fixes a couple mistakenly overwritten typepaths (#82896) ## About The Pull Request Fixes some stuff not existing because they weren't named good enough. Whoops. ## Why It's Good For The Game You know the deal ## Changelog :cl: fix: minebot shields are now actually orderable fix: vinegar may once again be crafted with wine, water, and sugar /:cl: * Fixes a couple mistakenly overwritten typepaths --------- Co-authored-by: FlufflesTheDog <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Fixes a couple mistakenly overwritten typepaths (#82896) ## About The Pull Request Fixes some stuff not existing because they weren't named good enough. Whoops. ## Why It's Good For The Game You know the deal ## Changelog :cl: fix: minebot shields are now actually orderable fix: vinegar may once again be crafted with wine, water, and sugar /:cl: * Fixes a couple mistakenly overwritten typepaths --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: FlufflesTheDog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1219
About The Pull Request
Fixes the early return on the override signal handlers so that ineligible airlocks don't receive engineering override.
Fixes CI relating to abductor airlock
How This Contributes To The Nova Sector Roleplay Experience
Fixes a bug where triggering engineering override from the comms console can lead to ineligible airlocks getting access.
Proof of Testing
Screenshots/Videos
dreamseeker_LDc7btZopX.mp4
Changelog
🆑 LT3
fix: Fixed ineligible airlocks from receiving engineering override when activated from the communications console
/:cl: