Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] pipebomb #2213

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[MIRROR] pipebomb #2213

merged 1 commit into from
Mar 1, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1214
Original PR: tgstation/tgstation#81529

About The Pull Request

image

removes IEDs, these are its replacement

image

this recipe produces a finished pipebomb

you can craft pipes (of the atmos kind) with some metal
then you can make it into a pair of halved pipes with a welder
then you stuff in items for extra effect (optional, only works if it does something)
then you put in welding fuel OR gunpowder (no other options as of now, gunpowder is a better explosive)
cable finishes that part
after that, you can attach an unsecured assembly to finish the bomb

also this is the math for the explosion, power is decided by fuel
image

using it in-hand activates the assembly, using it off-hand allows you to configure the assembly

Why It's Good For The Game

IEDs suck and stuff and this would be a better upgrade/replacement because with assemblies you could make a circuit sentient pipebomb or gift a pipebomb via cargo or something and gimmicks i guess

Changelog

🆑 mc-oofert
add: Pipebombs
del: Improvised Firebombs
/:cl:

* pipebomb (#81529)

## About The Pull Request


![image](https://github.com/tgstation/tgstation/assets/70376633/2c2a8ddf-d210-468b-9403-f7de4fa1fd9b)

removes IEDs, these are its replacement


![image](https://github.com/tgstation/tgstation/assets/70376633/95cc67d7-ed41-481b-9b9d-f31897fdb46d)

this recipe produces a finished pipebomb

you can craft pipes (of the atmos kind) with some metal
then you can make it into a pair of halved pipes with a welder
then you stuff in items for extra effect (optional, only works if it
does something)
then you put in welding fuel OR gunpowder (no other options as of now,
gunpowder is a better explosive)
cable finishes that part
after that, you can attach an unsecured assembly to finish the bomb

also this is the math for the explosion, power is decided by fuel

![image](https://github.com/tgstation/tgstation/assets/70376633/95ac3101-a2af-4bdc-9730-6c9c20195b59)

using it in-hand activates the assembly, using it off-hand allows you to
configure the assembly

## Why It's Good For The Game

IEDs suck and stuff and this would be a better upgrade/replacement
because with assemblies you could make a circuit sentient pipebomb or
gift a pipebomb via cargo or something and gimmicks i guess
## Changelog
:cl:
add: Pipebombs
del: Improvised Firebombs
/:cl:

* pipebomb

---------

Co-authored-by: jimmyl <[email protected]>
@Iajret Iajret merged commit 8e3fb02 into master Mar 1, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1214 branch March 1, 2024 14:06
AnywayFarus added a commit that referenced this pull request Mar 1, 2024
Iajret pushed a commit that referenced this pull request Apr 28, 2024
* Fixes pAIs permanently blocking requests (#82900)

## About The Pull Request

Removes pAI subsystem/card's reliance on clients and makes them
unstoppable, which didn't really make much sense for it to be this way
in the first place since it's something that has to always happen and is
something that isn't client-controlled.

Also removed case of ``usr`` use in ui act.

## Why It's Good For The Game

Closes tgstation/tgstation#70401

## Changelog

:cl:
fix: pAI requests should no longer randomly permanently break in a
round.
/:cl:

* Fixes pAIs permanently blocking requests

---------

Co-authored-by: John Willard <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 29, 2024
* Fixes pAIs permanently blocking requests (#82900)

## About The Pull Request

Removes pAI subsystem/card's reliance on clients and makes them
unstoppable, which didn't really make much sense for it to be this way
in the first place since it's something that has to always happen and is
something that isn't client-controlled.

Also removed case of ``usr`` use in ui act.

## Why It's Good For The Game

Closes tgstation/tgstation#70401

## Changelog

:cl:
fix: pAI requests should no longer randomly permanently break in a
round.
/:cl:

* Fixes pAIs permanently blocking requests

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: John Willard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants