[MIRROR] Fixes station trait jobs and bank accounts ignoring the concept of jobs being singletons #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ept of jobs being singletons (#1233) * Fixes station trait jobs and bank accounts ignoring the concept of jobs being singletons (#81756) ## About The Pull Request Jobs are singletons don't make new ones!! Also this tweaks job station traits slightly so that traits in the future support multiple slots without breaking * Fixes station trait jobs and bank accounts ignoring the concept of jobs being singletons --------- Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 28, 2024
* fix roleless poll ignores not working (#82911) Fixes tgstation/tgstation#82890 In some cases an alert poll had no role, like the monkey helmet, and because of that it skipped the eligibility check ## Changelog :cl: fix: All alert polls ignore option works /:cl: * fix roleless poll ignores not working --------- Co-authored-by: 13spacemen <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 29, 2024
* fix roleless poll ignores not working (#82911) Fixes tgstation/tgstation#82890 In some cases an alert poll had no role, like the monkey helmet, and because of that it skipped the eligibility check ## Changelog :cl: fix: All alert polls ignore option works /:cl: * fix roleless poll ignores not working --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: 13spacemen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1233
Original PR: tgstation/tgstation#81756
About The Pull Request
Jobs are singletons don't make new ones!!
Also this tweaks job station traits slightly so that traits in the future support multiple slots without breaking