[MIRROR] Refactors how CI is handled and cleans up signals #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactors how CI is handled and cleans up signals * Clean up unneeded if, addresses review
AnywayFarus
added a commit
that referenced
this pull request
Mar 4, 2024
Iajret
pushed a commit
that referenced
this pull request
May 14, 2024
…on (#2238) * Initial * Woops * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * changes * fix missing var * This got missed * Unneeded * Tabs * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Balancing * Docs * Wield Fix --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1244
About The Pull Request
This splits the proc for how CI is set into three procs, as well as it cleans up the signal handlers for CI. The signal handlers before where never executing, this fix makes them properly fire. This also fixes the surrender button not being removed upon death. (Fixes #1205)
As well as it cleans up and adds additional logging for admins, it also changes the color for the logs making them a little more readable (dark blue on gray was really hard to read sometimes)
How This Contributes To The Nova Sector Roleplay Experience
This is mostly code based, but it does clean up the hud when someone goes unconscious removing the surrender button when it wasn't before
Proof of Testing
Screenshots/Videos
dreamseeker_0i9wVXTTYt.mp4
Changelog
🆑 SomeRandomOwl
fix: If you die or fall unconscious with Combat Indicator turned on, you will properly lose CI and the surrender button
refactor: Refactored how Combat Indicator is handled in the backend
admin: Added additional logging for when someone dies / falls unconscious with CI on, as well as changed the color of the logs for readability.
/:cl: