Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [MODULAR] Character Headshots via files.byondhome.com #2247

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1262

About The Pull Request

This PR changes the character headshot preference to allow for URLs via files.byondhome.com, which is Byond's built-in file uploader for Byond members only.

How This Contributes To The Nova Sector Roleplay Experience

With the changes in this PR, players with a Byond membership can take advantage of their 20MB of hot-linkable online storage space for headshots. The file uploader can be accessed via logging into Byond.com, then click "Manage Account" (https://secure.byond.com/members/-/account), then click "Files" in the top row.

See the circled link:
image

Proof of Testing

Tested locally ok!

Screenshots/Videos

image

image

Changelog

🆑 A.C.M.O.
qol: Added support for adding Character Headshots via files.byondhome.com, for Byond members only.
/:cl:

Add support for files.byondhome.com to headshot.dm
@Iajret Iajret merged commit 977c4fc into master Mar 4, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1262 branch March 4, 2024 12:06
AnywayFarus added a commit that referenced this pull request Mar 4, 2024
Iajret pushed a commit that referenced this pull request Apr 30, 2024
* [gbp no update] fix: ethereal alt attack verb is "sear" (#82951)

forgot to add the alt attack verb to the r ight arm

also, unfortunately have to change "singe" because it ends in E and
bodypart unarmed attacks get "ed" appended to them

## Changelog
:cl:
fix: Ethereal unarmed attacks "sear" instead of "singe", which was buggy
/:cl:

* [gbp no update] fix: ethereal alt attack verb is "sear"

---------

Co-authored-by: 13spacemen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants