[MIRROR] moon smile effect durations fix #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moon smile effect durations fix (#81794) ## About The Pull Request Moon smile's durations had some syntax issues, causing their durations to be much lower than intended, and sanity having very low impact on it. Also adds a use of SANITY_MAXIMUM define, so that the calculation will still work if this value is ever changed. ## Why It's Good For The Game The moon did not smile. It was frowning. Frowning because it was bugged :( But with this fix it can smile again :) ## Changelog :cl: fix: fixed some issues when calculating the duration of moon smile's effects /:cl: * moon smile effect durations fix --------- Co-authored-by: ViktorKoL <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 6, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 30, 2024
…utters on northstar (#2250) * Fixes missing wires in tramstation, and fixes name of cmo shutters on northstar (#82955) ## About The Pull Request This pr fixes wires not connecting to tramstatation graven and turbine to smes This pr fixes the name of cmo office shutter button from robotics to cmo ## Why It's Good For The Game So power doesn't fail, and using the wrong names ## Changelog :cl: fix: Fixes tramstation gravgen wiring fix: Fixes tramstation turbine wiring fix: Fixes northstar cmo button name /:cl: * Fixes missing wires in tramstation, and fixes name of cmo shutters on northstar --------- Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1270
Original PR: tgstation/tgstation#81794
About The Pull Request
Moon smile's durations had some syntax issues, causing their durations to be much lower than intended, and sanity having very low impact on it. Also adds a use of SANITY_MAXIMUM define, so that the calculation will still work if this value is ever changed.
Why It's Good For The Game
The moon did not smile. It was frowning. Frowning because it was bugged :( But with this fix it can smile again :)
Changelog
🆑 ViktorKoL
fix: fixed some issues when calculating the duration of moon smile's effects
/:cl: