[MIRROR] Small bible / bullet catcher component code cleanup #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Small bible / bullet catcher component code cleanup (#81835) ## About The Pull Request Saw this weird use of storing a component in a var when it didn't really need to be so I just refactored it a little bit. * Small bible / bullet catcher component code cleanup --------- Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
May 2, 2024
… and payout of new bounty options (#2275) * civilian bounty control terminal displays bounty description and payout of new bounty options (#82987) ## About The Pull Request The green buttons for selecting one of three bounties now also display the description and payout. https://github.com/tgstation/tgstation/assets/94711066/53d7fb02-28be-4138-b3d8-9f7a4dd6a356 Fixes #81867 Sorta brings it back to how it used to look, I think? The payout was still in the code, just not being displayed. But I looked through the file history and could find NO EVIDENCE of the bounty console displaying the description in the past so I guess I hallucinated that. ## Why It's Good For The Game It's nice to be able to see the payout before you're locked into a bounty for 5 minutes. Also more chances to read the flavortext and it makes the buttons feel less barren. With some bounties it also gives a better idea of how to even get the thing before committing to it. ## Changelog :cl: fix: the civilian bounty control terminal displays the payout of new bounty options again qol: the civilian bounty control terminal displays the description of new bounty options /:cl: * civilian bounty control terminal displays bounty description and payout of new bounty options --------- Co-authored-by: kawoppi <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 3, 2024
… and payout of new bounty options (#2275) (#3146) * civilian bounty control terminal displays bounty description and payout of new bounty options (#82987) ## About The Pull Request The green buttons for selecting one of three bounties now also display the description and payout. https://github.com/tgstation/tgstation/assets/94711066/53d7fb02-28be-4138-b3d8-9f7a4dd6a356 Fixes #81867 Sorta brings it back to how it used to look, I think? The payout was still in the code, just not being displayed. But I looked through the file history and could find NO EVIDENCE of the bounty console displaying the description in the past so I guess I hallucinated that. ## Why It's Good For The Game It's nice to be able to see the payout before you're locked into a bounty for 5 minutes. Also more chances to read the flavortext and it makes the buttons feel less barren. With some bounties it also gives a better idea of how to even get the thing before committing to it. ## Changelog :cl: fix: the civilian bounty control terminal displays the payout of new bounty options again qol: the civilian bounty control terminal displays the description of new bounty options /:cl: * civilian bounty control terminal displays bounty description and payout of new bounty options --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: kawoppi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1291
Original PR: tgstation/tgstation#81835
About The Pull Request
Saw this weird use of storing a component in a var when it didn't really need to be so I just refactored it a little bit.