Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] worm farms take a little time to produce food, better fertilizer #228

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24477

About The Pull Request

it takes less time to insert food into the worm barrel-- the food is queued into creating the fertilizer on each cycle.
there was a var that was unused in any meaningful way, so it was removed as well as the useless times it was used.
increased some clarity regarding upgrading the ash farming plants-- as well as introduced fertilizer as a way to upgrade the crops rather than them producing crops; side note, regen cores will no longer produce crops.

How This Contributes To The Skyrat Roleplay Experience

the worm farm just... isn't as popular as I thought it would be. this PR is meant to make it have a more meaningful purpose within the confines of being an ash farmer (ashie or not). to upgrade crops, it was far too expensive (sinew and goliath hide).

Proof of Testing

Screenshots/Videos

image

Changelog

🆑 jjpark-kb
add: worm barrels will queue food now and create fertilizer on a cycle
add: fertilizer will now upgrade crops instead of producing crops
qol: increased clarity on examine text for ash crops: it will no longer display the message to upgrade if it is fully upgraded
del: removed regen cores from being usable on ash farms
balance: it is faster to insert food into the worm barrel
code: removed a meaningless var from ash farming components
code: moved some code to become procs for easier use for ash farming
/:cl:

…477)

* worm farms take a little time to produce food, better fertilizer

* Update modular_skyrat/modules/ashwalkers/code/buildings/ash_farming.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_skyrat/modules/ashwalkers/code/buildings/ash_farming.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_skyrat/modules/ashwalkers/code/buildings/ash_farming.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_skyrat/modules/ashwalkers/code/buildings/ash_farming.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_skyrat/modules/ashwalkers/code/buildings/ash_farming.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_skyrat/modules/ashwalkers/code/buildings/ash_farming.dm

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: Bloop <[email protected]>
@AnywayFarus AnywayFarus merged commit 399f855 into master Oct 23, 2023
23 checks passed
AnywayFarus added a commit that referenced this pull request Oct 23, 2023
@AnywayFarus AnywayFarus deleted the upstream-mirror-24477 branch October 23, 2023 08:06
Iajret pushed a commit that referenced this pull request Jan 3, 2024
* Fixes some division by zero

* Apply suggestions from code review

* Update death_consequences_trauma.dm

* Update liquid_turf.dm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants