[MIRROR] Adding a blood brother via the team panel sets it up correctly #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly (#1308) * Adding a blood brother via the team panel sets it up correctly (#81799) ## About The Pull Request In a recent round, it was noticed that it's kind of annoying and fiddly for an admin to add someone to a blood brother team (for instance, if they had to recreate someone's mob to fix a different issue). Now if you add someone to a blood brother team via the teams panel, it will set them up as a blood brother properly. It's probably in the future worth examining this behaviour for other team antags as well. I also added a link to the Team Panel to the Antag Panel because I had a skill issue and kept forgetting how to access it. Finally, the conversion logging looked all kinds of fucked, so I fixed it. I will be honest: I don't know what that list does but the arguments it was recording were both wrong and didn't make any sense. ## Why It's Good For The Game Makes admin lives easier. Using this panel you can now add sapient Ian to a blood brother team. ## Changelog :cl: admin: Made it easier for admins to adjust blood brother teams using admin tools. fix: Correct blood brother conversion logging. /:cl: * Adding a blood brother via the team panel sets it up correctly --------- Co-authored-by: Jacquerel <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 7, 2024
Iajret
pushed a commit
that referenced
this pull request
May 2, 2024
* rad shutter directionals (#82997) * rad shutter directionals --------- Co-authored-by: jimmyl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1308
Original PR: tgstation/tgstation#81799
About The Pull Request
In a recent round, it was noticed that it's kind of annoying and fiddly for an admin to add someone to a blood brother team (for instance, if they had to recreate someone's mob to fix a different issue).
Now if you add someone to a blood brother team via the teams panel, it will set them up as a blood brother properly.
It's probably in the future worth examining this behaviour for other team antags as well.
I also added a link to the Team Panel to the Antag Panel because I had a skill issue and kept forgetting how to access it.
Finally, the conversion logging looked all kinds of fucked, so I fixed it. I will be honest: I don't know what that list does but the arguments it was recording were both wrong and didn't make any sense.
Why It's Good For The Game
Makes admin lives easier.
Using this panel you can now add sapient Ian to a blood brother team.
Changelog
🆑 Jacquerel
admin: Made it easier for admins to adjust blood brother teams using admin tools.
fix: Correct blood brother conversion logging.
/:cl: