Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Unique icons for lock path spells #2286

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1301
Original PR: tgstation/tgstation#81832

About The Pull Request

Adds unique icons for several lock path spells: caretaker's refuge, apetra vulnera and ascended shapeshift.

lock_spells.mp4

Never added sprites before, so I hope nothing breaks. Also for some reason visual studio code really wanted to change some indentation on some empty lines in apetravulnera.dm, so there's some random changes, had no idea how to prevent it, and it doesn't seem to actually matter.

Why It's Good For The Game

These spells used to (except for ascended shapeshift) use icons that other heretic spells also used, potentially leading to confusion. Also it's nice to have unique icons for each spell.

Changelog

🆑 ViktorKoL
image: added unique icons for spells: caretaker's refuge, apetra vulnera and ascended shapechange
/:cl:

* Unique icons for lock path spells (#81832)

## About The Pull Request

Adds unique icons for several lock path spells: caretaker's refuge,
apetra vulnera and ascended shapeshift.


https://github.com/tgstation/tgstation/assets/44502667/8fe907bc-4da9-4007-97f2-445b26be3068

Never added sprites before, so I hope nothing breaks. Also for some
reason visual studio code really wanted to change some indentation on
some empty lines in apetravulnera.dm, so there's some random changes,
had no idea how to prevent it, and it doesn't seem to actually matter.
## Why It's Good For The Game

These spells used to (except for ascended shapeshift) use icons that
other heretic spells also used, potentially leading to confusion. Also
it's nice to have unique icons for each spell.
## Changelog
:cl:
image: added unique icons for spells: caretaker's refuge, apetra vulnera
and ascended shapechange
/:cl:

* Unique icons for lock path spells

---------

Co-authored-by: ViktorKoL <[email protected]>
@Iajret Iajret merged commit ebd5bba into master Mar 7, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1301 branch March 7, 2024 10:18
AnywayFarus added a commit that referenced this pull request Mar 7, 2024
Iajret pushed a commit that referenced this pull request May 2, 2024
* More Machine Blessing Options (#82606)

## About The Pull Request

Adds more implants to the pool that the Machine Blessing rite can draw
from, and rebalances the drop rates so that you're more likely to get
thematically-consistent implants.

## Why It's Good For The Game

Currently, the options for what the Machine Blessing rite can give you
are kinda garbage, considering that _one_ implant from the rite is the
same value as _two_ full species conversions. This adds a few more that
are actually useful.

Specific implants added:
- Combat arm (extremely low drop rate)
- Tool arm (higher drop rate)
- Reviver implant (lower drop rate)
- Anti-drop implant
- Anti-stun implant (significantly lower drop rate)
- Welding eyes

Additionally, slightly lowers the drop rate of the breathing tube
implant, because androids don't have lungs

## Changelog

:cl:
add: increased the size of the pool that Machine Blessing draws from
balance: weighted some of the implants that Machine Blessing can give
/:cl:

---------

Co-authored-by: Jacquerel <[email protected]>

* More Machine Blessing Options

---------

Co-authored-by: Zenog400 <[email protected]>
Co-authored-by: Jacquerel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants