Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Food Bar Updates, moves it out of the alert "stack" and to the left of mood, makes it more snappy #2293

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1304
Original PR: tgstation/tgstation#81834

About The Pull Request

  • Moves the Food Bar alert out of "alerts" an onto its own element.

    • This element sits right next to mood.
    • The "redness" around the bar when you're at low hunger now pulses.
  • Updates the graphics of the burger.

    • Allows any food item (well, any icon) to be drawn in place of the burger going forward. Neat.
2024-03-04.15-49-58.mp4
  • Adds intermediary food bar between normal nutrition level and "Fat".

    • Updates the moodlets to accomodate this.
    • You go from fed, to well fed, to "too well fed", to "fat" when your overeattime climbs.
  • Signalizes a bunch of food related things, and also puts a bunch of food related things onto the adjust-er procs rather than on their own.

    • Moodlets no longer check nutrition every mood tick to determine which moodle to apply.
    • Stomachs no longer check nutrition every life tick to determine which alert to apply.
    • Deletes set_safe_hunger_level, handles it via a no_hunger signal.
  • Minor code improvements to how alerts decide their location.

Why It's Good For The Game

  • Hunger's icon is old as hell, and could use a facelift. Now it opens up funny opportunities like changing hunger to show cabbage for vegans, or like, other people if you're a cannibal. Idk.

  • It being in the alert stack takes up valuable alert space that other, more pressing things (such as being on fire or choking) may want.

  • Making it a lot more snappy makes it a bit harder to accidentally become "fat'.

Changelog

🆑 Melbert
refactor: Food hunger bar has been refactored, and moved. Now it sits next to the moodlet face.
refactor: Food moodlets now update a lot more snappily. There is now a moodlet tier between "being fat" and "being normal", to reduce accidentally gorging yourself to "fatness" tier.
del: You can't hallucinate being hungry... for now.
/:cl:

…he left of mood, makes it more snappy (#1304)

* Food Bar Updates, moves it out of the alert "stack" and to the left of mood, makes it more snappy (#81834)

* Food Bar Updates, moves it out of the alert "stack" and to the left of mood, makes it more snappy

* Deprecated proc

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: Mal <[email protected]>
@Iajret Iajret merged commit 5a54704 into master Mar 7, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1304 branch March 7, 2024 10:20
AnywayFarus added a commit that referenced this pull request Mar 7, 2024
Iajret pushed a commit that referenced this pull request May 3, 2024
* fixes a few problems in ai targetting (#82998)

## About The Pull Request
fixes #82964 , fixes #82866

## Why It's Good For The Game
fixes several problems with ai targetting. this pr resolves civil war
that was brewing between several mobs. also fixes a major problem where
mobs would only search for targets and not perform any other behaviors.
also fixes a small problem where mobs would constantly stop and start
while chasing targets
## Changelog
:cl:
fix: mobs in the same faction will no longer be at odds against one
another
fix: mobs can now perform behaviors alongside searching for targets
fix: mobs will no longer be starting and stopping when chasing targets
/:cl:

* fixes a few problems in ai targetting

---------

Co-authored-by: Ben10Omintrix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants