[MIRROR] Spider web graphics #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Spider web graphics * Update icon_smoothing.dm --------- Co-authored-by: Jacquerel <[email protected]> Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 7, 2024
Iajret
pushed a commit
that referenced
this pull request
May 4, 2024
* Fix crafting bypassing checks * Modular * Modular * Update stone.dm * Update sheet_types.dm * Update sheet_types.dm * .. * Will this break things? * Revert "Will this break things?" This reverts commit 1da74cd4d1a5008a962fa385cec6eace3394c699. * wHOOPS * Update turfs.dm --------- Co-authored-by: Xander3359 <[email protected]> Co-authored-by: Mal <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 5, 2024
* Fix crafting bypassing checks * Modular * Modular * Update stone.dm * Update sheet_types.dm * Update sheet_types.dm * .. * Will this break things? * Revert "Will this break things?" This reverts commit 1da74cd4d1a5008a962fa385cec6eace3394c699. * wHOOPS * Update turfs.dm --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Xander3359 <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1305
Original PR: tgstation/tgstation#81839
About The Pull Request
Here is what webs look like.
It looks like pure ass and I hate seeing it.
Here's my attempt at making them look nicer.
Notes: Genetics Power webs now have a slight purple tint to differentiate them from regular spider webs, so spiders aren't confused about why they can't cross these ones.
On the backend I condensed a lot of these typepaths to inherit from each other instead of not doing that. In the future I am going to use this to cut down on the excessive amount of action buttons we have for these too.
Here's (most of) what the action buttons look like. this screenshot also demonstrating that we have a serious problem with how many buttons we give to spiders.
After this is merged I will embark on two further projects:
While I was working on this I noticed that AI spiders would not automatically place webs on certain crossable tiles, because we forgot to pass an argument to a proc. I fixed that too.
Oh also final change I almost forgot to document:
I made you jiggle if you get stuck in a web.
Why It's Good For The Game
The previous sprites looked bad and these look less bad.
Changelog
🆑 Jacquerel
fix: AI-controlled spiders can correctly recognise where they can place webs.
image: New sprites for most kinds of spider web
/:cl: