[MIRROR] [Semi-Modular] Ports over the old Food Prefs PR #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial Port - God Things are broken * Food perfs is on the tongue now * It builds Now - Time to test and fix * Button Now works and opens UI * Default Values Now Load in * ESLINT pass * This will hopefully shut CI up * More CI fixes * CI * Will this fix the last CI issue? * Ok i put the key back here now is that good enough * This should be all green now * Provides more user feedback and information * Make Neutral Buttons more visible * Consistency * This is not needed anymore With food perfs you can make yourself a vegetarian with the preferences it provides rather than by using quirks. * VERY SLIGHTLY MORE MODULAR Now its only additions and not removals * Ok last commit lies, this makes it not lie * Almost forgot this * apply suggestions [though semi broken] * Apply suggestions from code review * forgot to enable the disable * Update food.dm * Update flypeople.dm * Update flypeople.dm * Give people starting points to be more flexible * Update preferences_savefile.dm * Toxic foods counts towards dislikes * Update preferences_savefile.dm * Allows Obscure food prefs to be liked even when at maximum liked foods * Point Requirement Removal Inital * Remove numbers from UI, Fix CI * Ripping out the remnants of food points * Preserve Species Defaults * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Update food.dm * Liked food buttons now disable, obscure foods don't count * Moves food.dm, differentiates obscure foods. * Final Pass, EVERYTHING FINISHED --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 8, 2024
Iajret
pushed a commit
that referenced
this pull request
May 8, 2024
* draft * Update other_markings.dmi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#352
About The Pull Request
Adds food preferences back- mostly how they were before TGUI prefs, but now at least 80% more modular!
Has a few checks to make this less powerful and straight up better than the usual species food preferences like the version of yonder:
I've done this in like... six hours overall now, so folk might want to talk this over with me to figure out a good set of point values.
Food is equally nutritious regardless of if you like or dislike something.
How This Contributes To The Nova Sector Roleplay Experience
Being able to represent varying food cultures is quite nice, no?
This time with hopefully less folk picking literal garbage as a like, cause they now have to declare two things they don't like in exchange!
Proof of Testing
What it looks like!
Yv3R9HRyCV.mp4
Changelog
🆑 SomeRandomOwl
add: Added a food preference system! It has a few checks, but otherwise, gives you a huge amount of freedom to decide your tastes! Give it a peek in your character menu!
del: The quirks: Deviant Tastes, Pineapple Hater, Pineapple Liker, and Vegetarian have been hidden as a result meaning they will be removed from all characters who has taken these quirks to compensate for the fact you can set your preferences for food rather than take these quirks
/:cl: