[MIRROR] Fixes forensics hard del #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes forensics hard del (#81880) ## About The Pull Request Should fix this CI error.  `parent` used to be a weakref but since it's not any longer (as of #81751) we need to manage the ref more carefully. The forensic datum should be getting `QDEL_NULL`'d in `atom/Destroy()` but I think what was likely happening was somehow, something was adding a forensics datum again after the atom was qdeleted. This should hopefully prevent that from happening. ## Why It's Good For The Game Less CI errors ## Changelog Nothing player facing * Fixes forensics hard del --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1341
Original PR: tgstation/tgstation#81880
About The Pull Request
Should fix this CI error.
parentused to be a weakref but since it's not any longer (as of #81751) we need to manage the ref more carefully.The forensic datum should be getting
QDEL_NULL'd inatom/Destroy()but I think what was likely happening was somehow, something was adding a forensics datum again after the atom was qdeleted. This should hopefully prevent that from happening.Why It's Good For The Game
Less CI errors
Changelog
Nothing player facing