[MIRROR] Chem stun reductions now all use AdjustAllImmobility, and the AllImmobility procs now adjust unconscious #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e AllImmobility procs now adjust unconscious (#1352) * Chem stun reductions now all use AdjustAllImmobility, and the AllImmobility procs now adjust unconscious (#81873) ## About The Pull Request Meth, maints tar, synaptizine, and nicotine now all use the `AdjustAllImmobility` to handle their stun reductions, instead of individually adjusting all 5-6 immobility effects. `AllImmobility`, `SetAllImmobility`, and `AdjustAllImmobility` now also affect the unconscious status effect as well. I'm calling this a bug/consistency issue, since every chem that didn't already use `AdjustAllImmobility` was adjusting the unconscious status effect anyway, and they are all clearly trying to do the same thing. If I missed anything that could also be replaced with `AdjustAllImmobility`, let me know and I'll fix it. ## Why It's Good For The Game Makes things more consistent, and consistency is good. ## Changelog :cl: code: Chem stun reductions are now applied more consistently. fix: Chem stun reductions should now more consistently apply to unconsciousness. /:cl: * Chem stun reductions now all use AdjustAllImmobility, and the AllImmobility procs now adjust unconscious --------- Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1352
Original PR: tgstation/tgstation#81873
About The Pull Request
Meth, maints tar, synaptizine, and nicotine now all use the
AdjustAllImmobilityto handle their stun reductions, instead of individually adjusting all 5-6 immobility effects.AllImmobility,SetAllImmobility, andAdjustAllImmobilitynow also affect the unconscious status effect as well. I'm calling this a bug/consistency issue, since every chem that didn't already useAdjustAllImmobilitywas adjusting the unconscious status effect anyway, and they are all clearly trying to do the same thing.If I missed anything that could also be replaced with
AdjustAllImmobility, let me know and I'll fix it.Why It's Good For The Game
Makes things more consistent, and consistency is good.
Changelog
🆑 Momo8289
code: Chem stun reductions are now applied more consistently.
fix: Chem stun reductions should now more consistently apply to unconsciousness.
/:cl: