[MIRROR] Stops mines from blowing up CI #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stops mines from blowing up CI (#81881) ## About The Pull Request Makes this GO AWAY.  Fixes tgstation/tgstation#81249 Fixes NovaSector/NovaSector#930 Fixes NovaSector/NovaSector#1077 Half of tgstation/tgstation#81448 resolved by this. --- So landmines are very often _deciding to blow up during the unit tests_, causing the floor to not be a floor. This was always a potential issue but was exacerbated by the museum PR which made the following change:  --- **My solution is to stop them from spawning.** create_and_destroy is already a bug-minefield, it does not also need to be a _literal_ minefield. I've ran 4 tests so far and where this issue was cropping up every other PR, it has still not occurred with this fix. I'm not going to say for certain that it's fixed just yet but I am optimistic. I'll update in a few hours. edit: Unfortunately my optimism was misguided and on the 8th run it failed. This doesn't fix it. ## Why It's Good For The Game This CI error was coming up all the time and I'm sick of it. ## Changelog :cl: fix: fixes a spurious CI runtime caused by explosive mines quite literally blowing up the unit test area /:cl: * Stops mines from blowing up CI --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 12, 2024
Iajret
pushed a commit
that referenced
this pull request
May 8, 2024
* Adds a 'None' option to pod hair preferences * Whoop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1398
Original PR: tgstation/tgstation#81881
About The Pull Request
Makes this GO AWAY.
Fixes tgstation/tgstation#81249
Fixes NovaSector/NovaSector#930
Fixes NovaSector/NovaSector#1077
Half of tgstation/tgstation#81448 resolved by this.
So landmines are very often deciding to blow up during the unit tests, causing the floor to not be a floor.
This was always a potential issue but was exacerbated by the museum PR which made the following change:
My solution is to stop them from spawning. create_and_destroy is already a bug-minefield, it does not also need to be a literal minefield.
I've ran 4 tests so far and where this issue was cropping up every other PR, it has still not occurred with this fix. I'm not going to say for certain that it's fixed just yet but I am optimistic. I'll update in a few hours.
edit: Unfortunately my optimism was misguided and on the 8th run it failed. This doesn't fix it.
Why It's Good For The Game
This CI error was coming up all the time and I'm sick of it.
Changelog
🆑 vinylspiders
fix: fixes a spurious CI runtime caused by explosive mines quite literally blowing up the unit test area
/:cl: