Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes a broken path on the black market #2372

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1396
Original PR: tgstation/tgstation#81942

About The Pull Request

We have a misspelled path here for a black market fish case, which is creating a broken object called fish_cas

Why It's Good For The Game

🐛 💥 Fixes a rather basic path bug that I came across, simple as.

Changelog

🆑 ArcaneMusic
fix: The black market illegal fish case now correctly initializes.
/:cl:

* Fixes a broken path on the black market (#81942)

## About The Pull Request

We have a misspelled path here for a black market fish case, which is
creating a broken object called `fish_cas`

## Why It's Good For The Game

🐛 💥 Fixes a rather basic path bug that I came across, simple as.

## Changelog

:cl:
fix: The black market illegal fish case now correctly initializes.
/:cl:

* Fixes a broken path on the black market

---------

Co-authored-by: ArcaneMusic <[email protected]>
@Iajret Iajret merged commit 5597dec into master Mar 12, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1396 branch March 12, 2024 17:36
AnywayFarus added a commit that referenced this pull request Mar 12, 2024
Iajret pushed a commit that referenced this pull request May 8, 2024
* Adds a small fishing pool on metastation (#82721)

## About The Pull Request

Firstly adds `var/datum/fish_source/fishing_datum` to
`/turf/open/water`, allowing a much easier way of adding lootpools to
water tiles, and sets its default to `/datum/fish_source/portal`

Secondly, adds a small pool for fishing in the metastation garden. This
sadly means Betsy had to move in with the chickens.

## Why It's Good For The Game

Should show more people that fishing actually exists, and give you
something more to do in the face of chaos and murder.


![image](https://github.com/tgstation/tgstation/assets/49160555/023ddebe-5938-402c-97af-d5def27069be)

This is mostly a test run. I plan on following up with more pools on
other stations if people like this one

## Changelog
:cl: @MrEmre12, @Majkl-J 
add: Fishing pool introduced to metastation garden
refactor: All water tiles now handle fishing through a unified
fishing_datum variable
/:cl:

---------

Co-authored-by: Vire <[email protected]>

* Adds a small fishing pool on metastation

---------

Co-authored-by: Waterpig <[email protected]>
Co-authored-by: Vire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants