[MIRROR] Dynamic material colors applied for insertion animation into lathes #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lathes (#1412) * Dynamic material colors applied for insertion animation into lathes (#81692) ## About The Pull Request So you've noticed that when we insert say uranium into a techfab it shows us the proper green sheet getting consumed as the animation but when you insert that same uranium into an autolathe is shows us a blue sheet animation instead? Yup not realistic, this is because the autolathe has only 2 animation types one for inserting iron & the other for glass. Every material type would have to share these 2 animations making it look bland. Now the material color is blended on the icon itself allowing for the right color to be applied on the insertion animation Plus this also trims the sizes of our dmi files so it's a win overall https://github.com/tgstation/tgstation/assets/110812394/bb643691-8d3b-4822-8371-346c2d5e5be3 ## Changelog :cl: fix: inserting a material sheet into an lathes should show the correct animation color /:cl: * Dynamic material colors applied for insertion animation into lathes --------- Co-authored-by: SyncIt21 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 13, 2024
Iajret
pushed a commit
that referenced
this pull request
May 8, 2024
…le and jawed hook to the market. (#2384) * Unit test for black market items. Added missing bulwark module and jawed hook to the market. (#82972) ## About The Pull Request Jacq has come up with the suggestion of adding a unit test to the blackmarket. I agreed ~~and I think I deserve the NO GBP label because both of these missing items are actually my fault~~. ## Why It's Good For The Game Let's avoid issues like this in the future. ## Changelog :cl: fix: Added the missing bulwark MOD module and the jawed fishing hook to the black market. /:cl: * Unit test for black market items. Added missing bulwark module and jawed hook to the market. --------- Co-authored-by: Ghom <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
…le and jawed hook to the market. (#2384) (#3239) * Unit test for black market items. Added missing bulwark module and jawed hook to the market. (#82972) ## About The Pull Request Jacq has come up with the suggestion of adding a unit test to the blackmarket. I agreed ~~and I think I deserve the NO GBP label because both of these missing items are actually my fault~~. ## Why It's Good For The Game Let's avoid issues like this in the future. ## Changelog :cl: fix: Added the missing bulwark MOD module and the jawed fishing hook to the black market. /:cl: * Unit test for black market items. Added missing bulwark module and jawed hook to the market. --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1412
Original PR: tgstation/tgstation#81692
About The Pull Request
So you've noticed that when we insert say uranium into a techfab it shows us the proper green sheet getting consumed as the animation but when you insert that same uranium into an autolathe is shows us a blue sheet animation instead?
Yup not realistic, this is because the autolathe has only 2 animation types one for inserting iron & the other for glass. Every material type would have to share these 2 animations making it look bland.
Now the material color is blended on the icon itself allowing for the right color to be applied on the insertion animation
Plus this also trims the sizes of our dmi files so it's a win overall
Insertions.mp4
Changelog
🆑 SyncIt21
fix: inserting a material sheet into an lathes should show the correct animation color
/:cl: