[MIRROR] Basic Mobs Can Now Get Wet (and can therefore clear the slimed status effect)
#2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…med` status effect) (#1409) * Basic Mobs Can Now Get Wet (and can therefore clear the `slimed` status effect) (#81927) ## About The Pull Request A year ago in #73601 (b7da743e7dca0ed0b8f96b02e184d8aed230526a), we made it such that we wouldn't apply the `/datum/status_effect/fire_handler` to any basic mob that wasn't a "flammable" mob. However, guess what? The way we handle "wet stacks" is handled by a subtype, `/datum/status_effect/fire_handler/wet_stacks`. This means that any mob that wasn't flammable wouldn't also get wet, meaning that they would literally _never_ get the `slimed` status effect off them (since that is reliant on wet stacks). In order to rectify this, let's actually account for the case in the code to ensure that mobs that should get wet do get wet (I made it an opt-out flag because I can't think of a single mob that can't get wet and didn't want to balloon the diff trying to think of every mob that should be able to get wet, etc.), and now it's all fixed hunky-dory. ## Why It's Good For The Game Fixes #81888 Basic mobs should be able to get wet. It's an oversight with how the wet_stack handler is tacked onto the backend of the fire_handler latticework- ideally these two would be two separate systems (or it would at least not be named `fire_handler` so people don't make this confusion in the future without realizing that it handles more than just... `fire`) but I don't have time to do a full cleansing and refactor of this code. ## Changelog :cl: fix: All basic mobs are able to get wet. This means, among other things, that you can clear the "slimed" status effect off your holoparasite or dog or whatever. /:cl: * Basic Mobs Can Now Get Wet (and can therefore clear the `slimed` status effect) --------- Co-authored-by: san7890 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 13, 2024
Iajret
pushed a commit
that referenced
this pull request
May 9, 2024
* Lets roundstart slimes have hair colors again * Adds new pref for it * Update mutant_parts.dm * Some final fixes
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
* Lets roundstart slimes have hair colors again * Adds new pref for it * Update mutant_parts.dm * Some final fixes Co-authored-by: Bloop <[email protected]> Co-authored-by: Iajret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1409
Original PR: tgstation/tgstation#81927
About The Pull Request
A year ago in #73601 (b7da743e7dca0ed0b8f96b02e184d8aed230526a), we made it such that we wouldn't apply the
/datum/status_effect/fire_handlerto any basic mob that wasn't a "flammable" mob. However, guess what? The way we handle "wet stacks" is handled by a subtype,/datum/status_effect/fire_handler/wet_stacks. This means that any mob that wasn't flammable wouldn't also get wet, meaning that they would literally never get theslimedstatus effect off them (since that is reliant on wet stacks).In order to rectify this, let's actually account for the case in the code to ensure that mobs that should get wet do get wet (I made it an opt-out flag because I can't think of a single mob that can't get wet and didn't want to balloon the diff trying to think of every mob that should be able to get wet, etc.), and now it's all fixed hunky-dory.
Why It's Good For The Game
Fixes #81888
Basic mobs should be able to get wet. It's an oversight with how the wet_stack handler is tacked onto the backend of the fire_handler latticework- ideally these two would be two separate systems (or it would at least not be named
fire_handlerso people don't make this confusion in the future without realizing that it handles more than just...fire) but I don't have time to do a full cleansing and refactor of this code.Changelog
🆑 san7890
fix: All basic mobs are able to get wet. This means, among other things, that you can clear the "slimed" status effect off your holoparasite or dog or whatever.
/:cl: