[MIRROR] Replace error spaghetti in thunderdome kitchen #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(#24533) * Replace error spaghetti in thunderdome kitchen (#79183) ## About The Pull Request Thunderdome kitchen had the base spaghetti type in its fridges, which caused it to appear as "food" and with an error sprite. I replaced it with regular cooked spaghetti. ## Why It's Good For The Game The base type for spaghetti is not intended to be used anywhere directly ## Changelog :cl: fix: Replaced error spaghetti in thunderdome kitchen with regular cooked spaghetti /:cl: * Replace error spaghetti in thunderdome kitchen --------- Co-authored-by: cnleth <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Oct 24, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Makes searchbars more responsive (#80688) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Identified in Issue #80679: The current implementation of the search bar component incorporates a timeout mechanism that's conflicting with the controlled input behavior. This is leading to a race condition where user input is inconsistently modified due to the timeout. To address this, I've eliminated the timer and applied a uniform debounce of 200ms to all onInput events. This approach aims to enhance input responsiveness and prevent the erratic behavior previously observed. Basic code maintenance: The search bar component itself is in fabrication but used elsewhere, so I remade it as a functional component and placed it in /common instead. <details> <summary>video</summary>  </details> <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Protolathes are bearable again Fixes #80679 <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: fix: Protolathe input should feel more responsive. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Makes searchbars more responsive --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24533
Original PR: tgstation/tgstation#79183
About The Pull Request
Thunderdome kitchen had the base spaghetti type in its fridges, which caused it to appear as "food" and with an error sprite. I replaced it with regular cooked spaghetti.
Why It's Good For The Game
The base type for spaghetti is not intended to be used anywhere directly
Changelog
🆑 cnleth
fix: Replaced error spaghetti in thunderdome kitchen with regular cooked spaghetti
/:cl: