[MIRROR] Fixes lag in search bars #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes lag in search bars (#81968) ## About The Pull Request - Fixes #81132 - Fixes #80853 To properly reproduce the issue you only need to type slowly in the search bar(type the word "basic") of the shared engineering techfab in metastation. https://github.com/tgstation/tgstation/assets/110812394/1c2a5791-66e2-468a-9827-6541966c18a9 I don't fully understand why this fixes it so i need an explanation before it gets merged. This was implemented back in #80614 to fix this > Problem goes a little deeper than simply adding "selfClear" prop - ntos messenger is looking for more of a controlled component. Whenever messages are sent, it attempts to update the value in the input box But upon testing the chat messenger with this removed it appears to work fine so not sure what got fixed where but one thing i can assert is that it definitely has nothing to do with debounce. ## Changelog :cl: fix: search bars don't swallow characters or lag behind your typing speed /:cl: * Fixes lag in search bars --------- Co-authored-by: SyncIt21 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 13, 2024
Iajret
pushed a commit
that referenced
this pull request
May 8, 2024
* Fixes floating pixels on railings (#83118) ## About The Pull Request Someone pointed this out earlier, and I agree random pixels es no bueno   ## Why It's Good For The Game It's not ## Changelog :cl: fix: Removed stray pixels appearing on certain parts of railing /:cl: * Fixes floating pixels on railings --------- Co-authored-by: AMyriad <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
* Fixes floating pixels on railings (#83118) ## About The Pull Request Someone pointed this out earlier, and I agree random pixels es no bueno   ## Why It's Good For The Game It's not ## Changelog :cl: fix: Removed stray pixels appearing on certain parts of railing /:cl: * Fixes floating pixels on railings --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: AMyriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1421
Original PR: tgstation/tgstation#81968
About The Pull Request
To properly reproduce the issue you only need to type slowly in the search bar(type the word "basic") of the shared engineering techfab in metastation.
bandicam.2024-03-12.23-05-37-100.mp4
I don't fully understand why this fixes it so i need an explanation before it gets merged.
This was implemented back in #80614 to fix this
But upon testing the chat messenger with this removed it appears to work fine so not sure what got fixed where but one thing i can assert is that it definitely has nothing to do with debounce.
Changelog
🆑 SyncIt21
fix: search bars don't swallow characters or lag behind your typing speed
/:cl: