Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Gulag boulder mining adjustments #2393

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1423
Original PR: tgstation/tgstation#81971

About The Pull Request

This PR does two fairly simple things.
Firstly, it triples the gulag point value of every material except glass.
Secondly, it allows mining skill increases to effect the speed of boulder breaking and reduce the stamina "exertion" you take.

I tried this out personally on Lavaland and Icebox and while this is very much dependent on RNG (and storm timing) this got earning 1000 points purely from mining and smashing boulders down to about ten minutes of work, which I believe is the rough estimate of how much effort it was before that. It may skew a bit higher than that if the ash storm happens at a bad time or the game gives you predominantly iron, but not a lot higher.

The mining skill = faster smashing thing is... barely perceptible after ten minutes of mining to be honest but it's saving some time and I think if it gives you the exp it might as well benefit from it too.

I didn't do anything for glass because you can just pick that up off the ground in Lavaland and I didn't want to make that the ideal route to getting your sentence finished.

Why It's Good For The Game

Since ArcMining was merged, the gulag has changed to a system primarily about digging up boulders and smashing them with a pickaxe for random rewards. I think the chain gang thing is pretty flavourful, but the inability to just target high-value materials (because you could see them on the mining scanner) and the overall decrease in output has made it take a lot longer to get a similar amount of points.

People are sending prisoners out to mine for 1000 points of materials assuming this is about 10 minutes work, when in reality it was more like 30-35 minutes. Longer on Lavaland, where you need to take breaks for ash storms.

This was not an intentional "nerf" to prisoner miners and should hopefully bring it back down to somewhere closer to the previous level.

Changelog

🆑 Jacquerel
balance: All materials except glass are now worth more gulag points than before.
balance: Mining skill decreases the time it takes to break boulders, and makes it less tiring.
/:cl:

* Gulag boulder mining adjustments (#81971)

## About The Pull Request

This PR does two fairly simple things.
Firstly, it triples the gulag point value of every material except
glass.
Secondly, it allows mining skill increases to effect the speed of
boulder breaking and reduce the stamina "exertion" you take.

I tried this out personally on Lavaland and Icebox and while this is
very much dependent on RNG (and storm timing) this got earning 1000
points purely from mining and smashing boulders down to _about_ ten
minutes of work, which I believe is the rough estimate of how much
effort it was before that. It may skew a bit higher than that if the ash
storm happens at a bad time or the game gives you predominantly iron,
but not a _lot_ higher.

The mining skill = faster smashing thing is... barely perceptible after
ten minutes of mining to be honest but it's saving _some_ time and I
think if it gives you the exp it might as well benefit from it too.

I didn't do anything for _glass_ because you can just pick that up off
the ground in Lavaland and I didn't want to make _that_ the ideal route
to getting your sentence finished.

## Why It's Good For The Game

Since ArcMining was merged, the gulag has changed to a system primarily
about digging up boulders and smashing them with a pickaxe for random
rewards. I think the chain gang thing is pretty flavourful, but the
inability to just target high-value materials (because you could see
them on the mining scanner) and the overall decrease in output has made
it take a lot longer to get a similar amount of points.

People are sending prisoners out to mine for 1000 points of materials
assuming this is about 10 minutes work, when in reality it was more like
30-35 minutes. Longer on Lavaland, where you need to take breaks for ash
storms.

This was not an intentional "nerf" to prisoner miners and should
hopefully bring it back down to somewhere closer to the previous level.

## Changelog

:cl:
balance: All materials except glass are now worth more gulag points than
before.
balance: Mining skill decreases the time it takes to break boulders, and
makes it less tiring.
/:cl:

* Gulag boulder mining adjustments

---------

Co-authored-by: Jacquerel <[email protected]>
@ReezeBL ReezeBL merged commit f051967 into master Mar 14, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1423 branch March 14, 2024 08:04
AnywayFarus added a commit that referenced this pull request Mar 14, 2024
Iajret pushed a commit that referenced this pull request May 8, 2024
…#2393)

* Allows the Coroner's Ritual Knife to go in the Medical belt! (#83113)

## About The Pull Request
Allows the Ritual Knife from the Coroner's Mortidrobe contraband section
to be stored within Medical Belts like any other surgical tool.

## Why It's Good For The Game
Coroners using the Ritual Knife adds excellent flavor to the job.
Allowing it to sit upon their Medical Belt in place of, say, a scalpel
grants convenience to those wishing to roleplay out a more wicked or
occultic Coroner without having to place the Ritual Knife in their bag,
leaving an odd spot open on their Medical Belt.

* Allows the Coroner's Ritual Knife to go in the Medical belt!

---------

Co-authored-by: DrAmazing343 <[email protected]>
ReezeBL pushed a commit that referenced this pull request May 9, 2024
…#2393) (#3232)

* Allows the Coroner's Ritual Knife to go in the Medical belt! (#83113)

## About The Pull Request
Allows the Ritual Knife from the Coroner's Mortidrobe contraband section
to be stored within Medical Belts like any other surgical tool.

## Why It's Good For The Game
Coroners using the Ritual Knife adds excellent flavor to the job.
Allowing it to sit upon their Medical Belt in place of, say, a scalpel
grants convenience to those wishing to roleplay out a more wicked or
occultic Coroner without having to place the Ritual Knife in their bag,
leaving an odd spot open on their Medical Belt.

* Allows the Coroner's Ritual Knife to go in the Medical belt!

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: DrAmazing343 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants