[MIRROR] Clicking sub sections in lathes will auto scroll to them #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Clicking sub sections in lathes will auto scroll to them (#81933) ## About The Pull Request - Fixes #80931 To answer the question > Would be valid to see if it's actually getting the element. if it is, perhaps the issue is with section I guess the problem is with the section because `getElementByID()` requires the `div` element of the section to actually have an `id` which we can retrive & scroll to. I don't like the solution entirely as `key` & `id` are redundant and if there was a way to access the `key` or some other way to access the section without using `getElementByID()` I'm all up for it. ## Changelog :cl: fix: Clicking sub sections in the design menu of lathe's UIs will auto scroll to them. /:cl: * Clicking sub sections in lathes will auto scroll to them --------- Co-authored-by: SyncIt21 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 13, 2024
Iajret
pushed a commit
that referenced
this pull request
May 8, 2024
… Box (#2395) * Removes another rogue cable under a disconnected SMES on Ice Box (#83129) ## About The Pull Request I'm still surprised this didn't come up in the tests here, but here you go, now it's fixed properly. tgstation/tgstation#83059 forgot to notice that there was actually two rogue wires, not just one! ## Why It's Good For The Game Less CI failures == happier maintainers ## Changelog :cl: GoldenAlpharex fix: Removed another rogue cable from underneath a disconnected SMES. /:cl: * Removes another rogue cable under a disconnected SMES on Ice Box --------- Co-authored-by: GoldenAlpharex <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
… Box (#2395) (#3242) * Removes another rogue cable under a disconnected SMES on Ice Box (#83129) ## About The Pull Request I'm still surprised this didn't come up in the tests here, but here you go, now it's fixed properly. tgstation/tgstation#83059 forgot to notice that there was actually two rogue wires, not just one! ## Why It's Good For The Game Less CI failures == happier maintainers ## Changelog :cl: GoldenAlpharex fix: Removed another rogue cable from underneath a disconnected SMES. /:cl: * Removes another rogue cable under a disconnected SMES on Ice Box --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1430
Original PR: tgstation/tgstation#81933
About The Pull Request
To answer the question
I guess the problem is with the section because
getElementByID()requires thedivelement of the section to actually have anidwhich we can retrive & scroll to.I don't like the solution entirely as
key&idare redundant and if there was a way to access thekeyor some other way to access the section without usinggetElementByID()I'm all up for it.Changelog
🆑 SyncIt21
fix: Clicking sub sections in the design menu of lathe's UIs will auto scroll to them.
/:cl: