[MIRROR] Fixes Spontaneous Harddel with Boned Fish Revive Ability #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Fixes Spontaneous Harddel with Boned Fish Revive Ability (#81959) ## About The Pull Request You can find an example of the failing stack trace here: https://github.com/tgstation/tgstation/actions/runs/8242191499/job/22540786029?pr=81937#step:10:1323 Here's a screenshot:  Explanation: The boned fish's revive ability added a timer that would randomly fire in the next one-to-two minutes. Due to this inherent randomness, create-and-destroy would locate the fact that we were hanging refs to this fish since the timer may not have processed by the time the fish was deleted (probably if the timer was considerably more than one minute), so in order to fix this let's just add the `TIMER_DELETE_ME` flag to the revive ability so that the timer get's `qdel`'d on the fish's `Destroy()`. simple i probably cocked up some detail of the above explanation but the timer flag was literally created to prevent stuff like this from happening so let's use it ## Changelog don't matter * Fixes Spontaneous Harddel with Boned Fish Revive Ability --------- Co-authored-by: san7890 <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
May 9, 2024
* Fix conveyor switches not working for cyborgs (#83121) ## About The Pull Request Makes conveyor switches work for cyborgs again ## Why It's Good For The Game The left/right click update broke it. Fixes #83078 ## Changelog :cl: fix: conveyor switches work for cyborgs again /:cl: * Fix conveyor switches not working for cyborgs --------- Co-authored-by: Echriser <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
* Fix conveyor switches not working for cyborgs (#83121) ## About The Pull Request Makes conveyor switches work for cyborgs again ## Why It's Good For The Game The left/right click update broke it. Fixes #83078 ## Changelog :cl: fix: conveyor switches work for cyborgs again /:cl: * Fix conveyor switches not working for cyborgs --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Echriser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1426
Original PR: tgstation/tgstation#81959
About The Pull Request
You can find an example of the failing stack trace here: https://github.com/tgstation/tgstation/actions/runs/8242191499/job/22540786029?pr=81937#step:10:1323
Here's a screenshot:
Explanation: The boned fish's revive ability added a timer that would randomly fire in the next one-to-two minutes. Due to this inherent randomness, create-and-destroy would locate the fact that we were hanging refs to this fish since the timer may not have processed by the time the fish was deleted (probably if the timer was considerably more than one minute), so in order to fix this let's just add the
TIMER_DELETE_MEflag to the revive ability so that the timer get'sqdel'd on the fish'sDestroy(). simplei probably cocked up some detail of the above explanation but the timer flag was literally created to prevent stuff like this from happening so let's use it
Changelog
don't matter