[MIRROR] Adds a missing recharger to the Birdshot science testing range #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge (#1427) * Adds a missing recharger to the Birdshot science testing range (#81957) ## About The Pull Request As per the title, adds a recharger to the testing range in science on Birdshot. I noticed that this was missing from the room, and without it there's no way to recharge the nearby practice weaponry. So I added one for the practice weapons and for the consistency with testing ranges in other maps. ## Why It's Good For The Game If you have a firing range with (practice) weaponry and no way to recharge them after firing, it kind of sucks. By adding one, we both fix this problem and the inconsistency with other testing ranges. ## Changelog :cl: fix: A missing recharger has been added into science's testing range on Birdshot station. /:cl: * Adds a missing recharger to the Birdshot science testing range --------- Co-authored-by: Derpguy3 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 14, 2024
Iajret
pushed a commit
that referenced
this pull request
May 9, 2024
#2402) * Adds animation to objects sliding into or out of morgue trays (#83127) ## About The Pull Request https://github.com/tgstation/tgstation/assets/51863163/b0662ee7-8f67-42d3-95ca-31012556f4ee This effect is purely visual, objects are still "instantly" put into or out of the morgue itself. (Meaning you can't grab an object as it is being shifted in or taken out, nor can you move off the tray while it is sliding in or out.) Also applies to crematoriums. ## Why It's Good For The Game Adds a tiny bit of visual flair to help "sell" the effect that the tray belongs to the morgue container, rather than just appearing and disappearing. ## Changelog :cl: Melbert qol: Morgue trays (and the contents inside) are now animated on open and close /:cl: * Adds animation to objects sliding into or out of morgue trays --------- Co-authored-by: MrMelbert <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
#2402) (#3248) * Adds animation to objects sliding into or out of morgue trays (#83127) ## About The Pull Request https://github.com/tgstation/tgstation/assets/51863163/b0662ee7-8f67-42d3-95ca-31012556f4ee This effect is purely visual, objects are still "instantly" put into or out of the morgue itself. (Meaning you can't grab an object as it is being shifted in or taken out, nor can you move off the tray while it is sliding in or out.) Also applies to crematoriums. ## Why It's Good For The Game Adds a tiny bit of visual flair to help "sell" the effect that the tray belongs to the morgue container, rather than just appearing and disappearing. ## Changelog :cl: Melbert qol: Morgue trays (and the contents inside) are now animated on open and close /:cl: * Adds animation to objects sliding into or out of morgue trays --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1427
Original PR: tgstation/tgstation#81957
About The Pull Request
As per the title, adds a recharger to the testing range in science on Birdshot.
I noticed that this was missing from the room, and without it there's no way to recharge the nearby practice weaponry. So I added one for the practice weapons and for the consistency with testing ranges in other maps.
Why It's Good For The Game
If you have a firing range with (practice) weaponry and no way to recharge them after firing, it kind of sucks. By adding one, we both fix this problem and the inconsistency with other testing ranges.
Changelog
🆑 Derpguy3
fix: A missing recharger has been added into science's testing range on Birdshot station.
/:cl: