Dyne fixes3 #2412
Merged
Dyne fixes3 #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
<3 |
AnywayFarus
added a commit
that referenced
this pull request
Mar 20, 2024
Iajret
pushed a commit
that referenced
this pull request
May 9, 2024
) * Command bar typing indicators (client side html version) (#83081) This uses a browser skin element to spy on the command bar and report back to the server what verb is currently in it and how many characters it has. it skips reporting if the text hasn't changed since the last report. im intentionally not providing the full text in the command bar to the server, while designing the system so new verbs can be given typing indicators by editing DM code, not html code. The report rate is once a second but this could be lowered or tweaked. Both the tgui say window being open and this system being active because the command bar starts with `say "` is undefined behavior, mostly the first one to end the indicator will just freeze indicators for the other one until it too ends its current indicator session. The system waits until something besides the `"` is in the argument to say. It is enabled for verbs `say`, `me`, and `whisper`. I don't actually know if this is the case for tgui say. this is a one line tweak anyways so let me know if this should be changed. [(This pr closes a bounty)](https://tgstation13.org/phpBB/viewtopic.php?p=726634#p726634) :cl: MrStonedOne & Lilah Novi add: Say commands typed in the command bar now trigger typing indicators /:cl: --------- Co-authored-by: san7890 <[email protected]> * Command bar typing indicators (client side html version) --------- Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: san7890 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
) (#3259) * Command bar typing indicators (client side html version) (#83081) This uses a browser skin element to spy on the command bar and report back to the server what verb is currently in it and how many characters it has. it skips reporting if the text hasn't changed since the last report. im intentionally not providing the full text in the command bar to the server, while designing the system so new verbs can be given typing indicators by editing DM code, not html code. The report rate is once a second but this could be lowered or tweaked. Both the tgui say window being open and this system being active because the command bar starts with `say "` is undefined behavior, mostly the first one to end the indicator will just freeze indicators for the other one until it too ends its current indicator session. The system waits until something besides the `"` is in the argument to say. It is enabled for verbs `say`, `me`, and `whisper`. I don't actually know if this is the case for tgui say. this is a one line tweak anyways so let me know if this should be changed. [(This pr closes a bounty)](https://tgstation13.org/phpBB/viewtopic.php?p=726634#p726634) :cl: MrStonedOne & Lilah Novi add: Say commands typed in the command bar now trigger typing indicators /:cl: --------- * Command bar typing indicators (client side html version) --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: san7890 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes machine frames for Interdyne, moves shuttle console vi indoors, expands perimeter fence, fixes some deco, some rrs.
Why It's Good For The Game
Fixes are nice.
Changelog
🆑
fix: fixed a few Dyne things
/:cl: