[MIRROR] Fixes timezone offset #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes timezone offset (#81993) ## About The Pull Request I'm gonna start off by saying I am in EST, which is important to this PR. Ever run a local server while not living in the UK and realizing that time is just frozen for you? Basically, this is why. We have ``GLOB.timezoneOffset`` which basically the time difference between BYOND's default timezone, UTC, and the timezone the server is being hosted in, however when you open a local host you may find that this isn't the case.  This should be 144000 for me (results may vary on your location) because of my timezone   514 did mess a little bit with timezones, adding a new arg in ``time2text``  But it also added a new var, ``world.timezone``, which handles basically everything we want for timezone offset stuff. By default, this is UTC, which is perfect for our case.  So I just swapped out our non-functional ``time2text(0,"hh")`` with ``world.timezone``, and  Incredible! It works! Time is even ticking again!  What an amazing feat, thanks 514! ## Why It's Good For The Game Closes tgstation/tgstation#81180 ## Changelog :cl: fix: Time on servers hosted outside of the UK should now properly have their timezone offset. /:cl: * Fixes timezone offset --------- Co-authored-by: John Willard <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 17, 2024
Iajret
pushed a commit
that referenced
this pull request
May 10, 2024
* Chance to become crab on DNA meltdown (#82985) ## About The Pull Request Sometimes when you get a nonlethal instability consequence you will now become crab ## Why It's Good For The Game You should be abel to reach teh peak of evolution when messing with your genetics ## Changelog :cl: add: Chance to become crab on nonlethal DNA meltdown /:cl: * Chance to become crab on DNA meltdown --------- Co-authored-by: carlarctg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1453
Original PR: tgstation/tgstation#81993
About The Pull Request
I'm gonna start off by saying I am in EST, which is important to this PR.
Ever run a local server while not living in the UK and realizing that time is just frozen for you? Basically, this is why.
We have
GLOB.timezoneOffsetwhich basically the time difference between BYOND's default timezone, UTC, and the timezone the server is being hosted in, however when you open a local host you may find that this isn't the case.This should be 144000 for me (results may vary on your location) because of my timezone
514 did mess a little bit with timezones, adding a new arg in
time2textBut it also added a new var,
world.timezone, which handles basically everything we want for timezone offset stuff. By default, this is UTC, which is perfect for our case.So I just swapped out our non-functional
time2text(0,"hh")withworld.timezone, andIncredible! It works!
Time is even ticking again!
What an amazing feat, thanks 514!
Why It's Good For The Game
Closes tgstation/tgstation#81180
Changelog
🆑 JohnFulpWillard
fix: Time on servers hosted outside of the UK should now properly have their timezone offset.
/:cl: