Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Several pipe cap visibility fixes #2430

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1460
Original PR: tgstation/tgstation#81999

About The Pull Request

  • Fixes cap overlays being added to turf even when pipe is not hidden.
  • Fixes cap overlays being visible on turfs that are masked with darkness plane, but still visible via mesons, cameras etc.

Why It's Good For The Game

Seeing caps over “invisible” turfs via cameras, mesons, and other means is actually a bug 'cause other pipes are hidden.

amongus

Changelog

🆑 intercepti0n
fix: Fixed cap overlay being added even when pipe is not hidden.
fix: Fixed cap overlay being visible on turfs that are masked with darkness plane, but still visible via mesons, cameras etc.
/:cl:

* [NO GBP] Several pipe cap visibility fixes (#81999)

## About The Pull Request

- Fixes cap overlays being added to turf even when pipe is not hidden.
- Fixes cap overlays being visible on turfs that are masked with
darkness plane, but still visible via mesons, cameras etc.

## Why It's Good For The Game

Seeing caps over “invisible” turfs via cameras, mesons, and other means
is actually a bug 'cause other pipes are hidden.


![amongus](https://github.com/tgstation/tgstation/assets/137328283/14ea7e70-1291-4487-b899-f4c4117c66c9)

## Changelog

:cl:
fix: Fixed cap overlay being added even when pipe is not hidden.
fix: Fixed cap overlay being visible on turfs that are masked with
darkness plane, but still visible via mesons, cameras etc.
/:cl:

* [NO GBP] Several pipe cap visibility fixes

---------

Co-authored-by: Interception&? <[email protected]>
@ReezeBL ReezeBL merged commit 1546d9c into master Mar 17, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1460 branch March 17, 2024 00:12
AnywayFarus added a commit that referenced this pull request Mar 17, 2024
Iajret pushed a commit that referenced this pull request May 11, 2024
…de metabolization rate (#2430)

* aagh

* oops

* i screwed up

* get it out of the vendor you fool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants