[MIRROR] Fix modsuit pathfinder module / JPS changes #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix modsuit pathfinder module / JPS changes (#81983) ## About The Pull Request The Pathfinder module sucks cock because it doesn't work. And the reasons it doesn't work are as follows: 1. It uses the default JPS pathfinding datum, which has a hard distance limit of 30, instead of the intended 200. 2. JPS pathfinding as a whole will fail if you encounter more than 3 doors. This is because every door wastes about 5 movement opportunities, and the default pathfinder only has a limit of 20 before it considers the entire pathfinding attempt moot and bails out. Here's how I fixed it: 1. Created a new jps child that has a range of MOD_AI_RANGE 2. Instead of counting all failures during the entire pathfinding attempt, it will only consider consecutive failures. Every successful move will reset the pathfinding failure count. This should make JPS pathfinding more reliable overall? ## Changelog :cl: fix: Modsuit Pathfinder module is significantly better at finding it's destination. /:cl: * Fix modsuit pathfinder module / JPS changes --------- Co-authored-by: Kapu1178 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 17, 2024
Iajret
pushed a commit
that referenced
this pull request
May 11, 2024
…hortens heating time (#2431) * sdwedw * why did i make this so high??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1461
Original PR: tgstation/tgstation#81983
About The Pull Request
The Pathfinder module sucks cock because it doesn't work. And the reasons it doesn't work are as follows:
Here's how I fixed it:
Changelog
🆑 Kapu1178
fix: Modsuit Pathfinder module is significantly better at finding it's destination.
/:cl: