[MIRROR] Fix polling mutating its target's plane and layer #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix polling mutating its target's plane and layer (#82009) ## About The Pull Request This PR fixes polling for an atom causing its plane and layer to mutate ```dm var/mutable_appearance/picture_source = alert_pic poll_image = picture_source ``` ```dm poll_image.layer = FLOAT_LAYER poll_image.plane = poll_alert_button.plane ``` See the issue? Passing an atom as an `alert_pic` would set `poll_image = alert_pic` which would in turn change `poll_image`'s plane and layer This is supposed to be `new(alert_pic)`, to make a mutable appearance *based on* the atom's appearance. I also did a minor bit of cleanup ## Changelog :cl: Melbert fix: Fixes polling for things causing said things to have their planes and layers screwed up (causing random objects or mobs to appear above runechat and blindness, for example) /:cl: * Fix polling mutating its target's plane and layer --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 17, 2024
Iajret
pushed a commit
that referenced
this pull request
May 14, 2024
* Update pistol.dm * Update submachinegun.dm * Update magazines.dm * Update pistol.dm * Update submachinegun.dm * Update pistol.dm
ReezeBL
pushed a commit
that referenced
this pull request
May 16, 2024
* Update pistol.dm * Update submachinegun.dm * Update magazines.dm * Update pistol.dm * Update submachinegun.dm * Update pistol.dm Co-authored-by: RatFromTheJungle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1464
Original PR: tgstation/tgstation#82009
About The Pull Request
This PR fixes polling for an atom causing its plane and layer to mutate
See the issue?
Passing an atom as an
alert_picwould setpoll_image = alert_picwhich would in turn changepoll_image's plane and layerThis is supposed to be
new(alert_pic), to make a mutable appearance based on the atom's appearance.I also did a minor bit of cleanup
Changelog
🆑 Melbert
fix: Fixes polling for things causing said things to have their planes and layers screwed up (causing random objects or mobs to appear above runechat and blindness, for example)
/:cl: