Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds a persistent piggy bank to the vault. #2444

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1447
Original PR: tgstation/tgstation#81900

About The Pull Request

This PR adds a persistent piggy bank to the station vault that, while it can hold up to 3300 credits carried between shifts. However, you can only insert up to 1600 (on top of the 50 creds it auto-generates) each shift, so it does take a small, itsy bitsy of patience to fill it to the brim.

Why It's Good For The Game

I put some effort coding persistent piggy banks when making the cafeteria PR for the museum away mission a while ago (which apparently isn't enabled yet because the key holders forgot to ig). It'd be a shame of all the existing code were only used for a single persistent piggy bank.

Changelog

🆑 Ghommie
add: Added a persistent piggy bank to the vault, which can carry up to a modest 2000 credits worth of dosh between rounds.
/:cl:

* Adds a persistent piggy bank to the vault. (#81900)

## About The Pull Request
This PR adds a **persistent** piggy bank to the station vault that,
while it can hold up to 3300 credits carried between shifts. However,
you can only insert up to 1600 (on top of the 50 creds it
auto-generates) each shift, so it does take a small, itsy bitsy of
patience to fill it to the brim.

## Why It's Good For The Game
I put some effort coding persistent piggy banks when making the
cafeteria PR for the museum away mission a while ago (which apparently
isn't enabled yet because the key holders forgot to ig). It'd be a shame
of all the existing code were only used for a single persistent piggy
bank.

* Adds a persistent piggy bank to the vault.

* 1

---------

Co-authored-by: Ghom <[email protected]>
Co-authored-by: Zergspower <[email protected]>
@ReezeBL
Copy link
Contributor

ReezeBL commented Mar 17, 2024

утром посмотрю.. наверное..

@Iajret Iajret merged commit a32be7c into master Mar 20, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-1447 branch March 20, 2024 09:37
AnywayFarus added a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants