Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes plasmaman nukeop reinforcements being given the wrong outfits #2458

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1499
Original PR: tgstation/tgstation#82004

About The Pull Request

This updates the plasmaman species outfit registry to consider all reinforcement outfits the game can pick for you. I mistakenly only overwrote the base type of reinforcement costumes, meaning plasmamen wouldn't actually be given a plasmaman outfit and would burst into flames and die upon spawning.

Now, every reinforcement outfit redirects to the base plasmaman reinforcement outfit, because making 5 new plasmaman variants of existing outfits felt like an unwieldy solution.

Why It's Good For The Game

I was told that plasmamen die when spawned in as nukie reinforcements. They probably shouldn't be doing that.

Changelog

🆑 Rhials
fix: Plasmamen nukie reinforcements are now properly given a plasmaman-safe outfit.
/:cl:

…he wrong outfits (#1499)

* [NO GBP] Fixes plasmaman nukeop reinforcements being given the wrong outfits (#82004)

## About The Pull Request

This updates the plasmaman species outfit registry to consider all
reinforcement outfits the game can pick for you. I mistakenly only
overwrote the base type of reinforcement costumes, meaning plasmamen
wouldn't actually be given a plasmaman outfit and would burst into
flames and die upon spawning.

Now, every reinforcement outfit redirects to the base plasmaman
reinforcement outfit, because making 5 new plasmaman variants of
existing outfits felt like an unwieldy solution.
## Why It's Good For The Game

I was told that plasmamen die when spawned in as nukie reinforcements.
They probably shouldn't be doing that.
## Changelog
:cl: Rhials
fix: Plasmamen nukie reinforcements are now properly given a
plasmaman-safe outfit.
/:cl:

* [NO GBP] Fixes plasmaman nukeop reinforcements being given the wrong outfits

---------

Co-authored-by: Rhials <[email protected]>
@ReezeBL ReezeBL merged commit 7dd5293 into master Mar 18, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1499 branch March 18, 2024 13:53
AnywayFarus added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants