Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes Headsets Being Wonky On Non-Poly Parrots #2459

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1501
Original PR: tgstation/tgstation#82046

About The Pull Request

Fixes #81861

Basically we just typecasted too hard on the headset strippable item so it was impossible to get headsets from non-Poly parrots. pretty silly mistake because literally everything else is meant to typecast to just /mob/living/basic/parrot. one line fix and leroy jenkins

Why It's Good For The Game

parrots shouldn't "eat" headsets and make them entirely unretrievable once placed on their ears.

Changelog

🆑 san7890
fix: If you place a headset on a non-Poly Parrot, you should be able to remove it from the parrot as-expected now rather than having the parrot send it to the shadow realm.
/:cl:

* Fixes Headsets Being Wonky On Non-Poly Parrots (#82046)

## About The Pull Request

Fixes #81861

Basically we just typecasted too hard on the headset strippable item so
it was impossible to get headsets from non-Poly parrots. pretty silly
mistake because literally everything else is meant to typecast to just
`/mob/living/basic/parrot`. one line fix and leroy jenkins
## Why It's Good For The Game

parrots shouldn't "eat" headsets and make them entirely unretrievable
once placed on their ears.
## Changelog
:cl:
fix: If you place a headset on a non-Poly Parrot, you should be able to
remove it from the parrot as-expected now rather than having the parrot
send it to the shadow realm.
/:cl:

* Fixes Headsets Being Wonky On Non-Poly Parrots

---------

Co-authored-by: san7890 <[email protected]>
@ReezeBL ReezeBL merged commit ffe9b0d into master Mar 18, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1501 branch March 18, 2024 13:54
AnywayFarus added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants