[MIRROR] Dice roll messages now properly detect if the die was rolled inhand or thrown #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inhand or thrown (#1504) * Dice roll messages now properly detect if the die was rolled inhand or thrown (#81977) ## About The Pull Request Currently, dice will give the same message directly to the user, regardless of if they were thrown or rolled in hand. This means you can throw a die far off screen or even out into space, and still know exactly when the die landed and what was rolled despite not being able to see it. This PR fixes that. It also rearranges the code for dice a little bit, since for some reason all the important procs were defined like, halfway down the file from the initial `/obj/item/dice` definition. ## Why It's Good For The Game Fixes a bug and something potentially exploitable ## Changelog :cl: fix: You can no longer determine the result of a dice roll from off-screen. /:cl: --------- Co-authored-by: san7890 <[email protected]> * Dice roll messages now properly detect if the die was rolled inhand or thrown --------- Co-authored-by: Nick <[email protected]> Co-authored-by: san7890 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 18, 2024
Iajret
pushed a commit
that referenced
this pull request
May 21, 2024
* MODsuit life support failure damage is stopped by stasis * Allow emergency entombed reactivation via strip menu * Ensure entombed MOD pieces always return to the suit and unset NODROP if the unit drops somehow * Satisfy linters * Return after component qdel & nullcheck just in case * Update modular_nova/master_files/code/modules/entombed_quirk/code/entombed_mod.dm --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1504
Original PR: tgstation/tgstation#81977
About The Pull Request
Currently, dice will give the same message directly to the user, regardless of if they were thrown or rolled in hand. This means you can throw a die far off screen or even out into space, and still know exactly when the die landed and what was rolled despite not being able to see it. This PR fixes that.
It also rearranges the code for dice a little bit, since for some reason all the important procs were defined like, halfway down the file from the initial
/obj/item/dicedefinition.Why It's Good For The Game
Fixes a bug and something potentially exploitable
Changelog
🆑 Momo8289
fix: You can no longer determine the result of a dice roll from off-screen.
/:cl: