Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Request GaGsification - Gis #2463

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[MIRROR] Request GaGsification - Gis #2463

merged 1 commit into from
Mar 20, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1500
Original PR: tgstation/tgstation#82040

About The Pull Request

This GAGsification is a request from Fitz Sholl, using their wonderful sprites to breathe some new life into a mostly forgotten outfit.
EDIT: I increased the available amount from 1 to 4. Meaning that a robust Sensei can have a class of three
image

there's also a second version which is a rendition of the prexisting one which I couldn't bring myself to delete completely, DBZ was a massive part of my childhood and will never leave me.

image

Why It's Good For The Game

As Bruce Lee was reported saying, "Be like water, water can flow, or water can crash" What does that mean? I don't know exactly, but it's cool as hell, look like water while handing out an absolute savage beating? You can now.

Changelog

🆑 xXPawnStarrXx
image: modified gi sprites, making them more customisable.
/:cl:

* Request GaGsification - Gis (#82040)

## About The Pull Request
This GAGsification is a request from Fitz Sholl, using their wonderful
sprites to breathe some new life into a mostly forgotten outfit.
EDIT: I increased the available amount from 1 to 4. Meaning that a
robust Sensei can have a class of three

![image](https://github.com/tgstation/tgstation/assets/53197594/f52f4021-49a9-4ac6-880f-860735766afe)

~~there's also a second version which is a rendition of the prexisting
one which I couldn't bring myself to delete completely, DBZ was a
massive part of my childhood and will never leave me.~~


![image](https://github.com/tgstation/tgstation/assets/53197594/111c88ff-280e-4e9f-8aa5-114cb9d73bf1)
## Why It's Good For The Game
As Bruce Lee was reported saying, "Be like water, water can flow, or
water can crash" What does that mean? I don't know exactly, but it's
cool as hell, look like water while handing out an absolute savage
beating? You can now.
## Changelog
:cl:
image: modified gi sprites, making them more customisable.
/:cl:

* Request GaGsification - Gis

---------

Co-authored-by: xXPawnStarrXx <[email protected]>
@ReezeBL ReezeBL merged commit f0090dd into master Mar 20, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1500 branch March 20, 2024 07:21
AnywayFarus added a commit that referenced this pull request Mar 20, 2024
Iajret pushed a commit that referenced this pull request May 15, 2024
* Fixes a reversion to the greyscale plate armor (#83214)

## About The Pull Request

tgstation/tgstation#82288 reverted these sprites
to a prior, worse state. This restores the sprites.

## Why It's Good For The Game

Please check your icon diffs when you make a pr. Particularly if the PR
has been up for a really long time and things are being merged at the
same time. Do NOT simply merge from master and overwrite dmi's when a
conflict occurs on a .dmi file.

We slowly lose sprites over time due to this, and I might be the only
person who actually checks for these reversions.

## Changelog
:cl:
fix: Fixes an accidental reversion to greyscale plate armor.
/:cl:

* Fixes a reversion to the greyscale plate armor

---------

Co-authored-by: necromanceranne <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
ReezeBL pushed a commit that referenced this pull request May 15, 2024
* Fixes a reversion to the greyscale plate armor (#83214)

## About The Pull Request

tgstation/tgstation#82288 reverted these sprites
to a prior, worse state. This restores the sprites.

## Why It's Good For The Game

Please check your icon diffs when you make a pr. Particularly if the PR
has been up for a really long time and things are being merged at the
same time. Do NOT simply merge from master and overwrite dmi's when a
conflict occurs on a .dmi file.

We slowly lose sprites over time due to this, and I might be the only
person who actually checks for these reversions.

## Changelog
:cl:
fix: Fixes an accidental reversion to greyscale plate armor.
/:cl:

* Fixes a reversion to the greyscale plate armor

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: necromanceranne <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants