[MIRROR] Fixes an issue with strip menus making duplicate windows #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Fixes an issue with strip menus making duplicate windows (#82055) ## About The Pull Request Fixes an oversight in #57889, where the strip_menus list is set, but never accessed, leading to whenever you drag to open the menu, it always opens a new window. ## Why It's Good For The Game Noticed this while porting the TGUI strip menu, and I figured I should fix it here too. From the design of the strippable element, it seems that this was the original design, but somehow got lost along the way. ## Changelog :cl: Fix: Opening a mob's strip menu multiple times will now properly update the window. /:cl: * Fixes an issue with strip menus making duplicate windows --------- Co-authored-by: Contrabang <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
May 15, 2024
* allows the SC/FISHER to shoot floor lights (#83182) ## About The Pull Request Lowers the hit threshold layer of SC/FISHER bolts from `PROJECTILE_HIT_THRESHHOLD_LAYER` (2.75) to `LOW_OBJ_LAYER` (2.5), allowing you to shoot floor lights with it. ## Why It's Good For The Game floor lights count as lightbulbs and therefore you should be able to explode them with the gun that explodes lightbulbs ## Changelog :cl: fix: The SC/FISHER can now shoot floor lights. /:cl: Co-authored-by: Hatterhat <[email protected]> * allows the SC/FISHER to shoot floor lights --------- Co-authored-by: Hatterhat <[email protected]> Co-authored-by: Hatterhat <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 15, 2024
* allows the SC/FISHER to shoot floor lights (#83182) ## About The Pull Request Lowers the hit threshold layer of SC/FISHER bolts from `PROJECTILE_HIT_THRESHHOLD_LAYER` (2.75) to `LOW_OBJ_LAYER` (2.5), allowing you to shoot floor lights with it. ## Why It's Good For The Game floor lights count as lightbulbs and therefore you should be able to explode them with the gun that explodes lightbulbs ## Changelog :cl: fix: The SC/FISHER can now shoot floor lights. /:cl: * allows the SC/FISHER to shoot floor lights --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Hatterhat <[email protected]> Co-authored-by: Hatterhat <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1515
Original PR: tgstation/tgstation#82055
About The Pull Request
Fixes an oversight in #57889, where the strip_menus list is set, but never accessed, leading to whenever you drag to open the menu, it always opens a new window.
Why It's Good For The Game
Noticed this while porting the TGUI strip menu, and I figured I should fix it here too. From the design of the strippable element, it seems that this was the original design, but somehow got lost along the way.
Changelog
🆑 Contrabang
Fix: Opening a mob's strip menu multiple times will now properly update the window.
/:cl: