[MIRROR] Fixes action_type on clothing to be a list on two items that where static #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tems that where static (#1524) * [NO GBP] Fixes action_type on clothing to be a list on two items that where static (#82075) ## About The Pull Request This changes the action_types on the face scarf from being a static datum to being a list. This is a bug I noticed while working on a PR downstream where i was attempting to add an action to a set of items and this caused a miss-matched type CI error. This realistically shouldn't be the case as everything else on the code base that uses action_types is also a list. So for consistency sake and to remove bugs this will fix the var to be a list instead of static. ## Why It's Good For The Game Less bugs, more consistency with variables. ## Changelog I don't really think this needs a change log, not really player noticeable or player facing. The relative impact on players is minor * [NO GBP] Fixes action_type on clothing to be a list on two items that where static --------- Co-authored-by: SomeRandomOwl <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
May 15, 2024
* Staff of Shrinking for the wizard (#83115) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds a new staff for the wizard that shoots shrink rays. Also a corresponding wand that comes with the wand belt. Shrinking is a mechanic already implemented by abductors, but it's not often used because it doesn't fit their kit super well. That's a huge shame because shrinking stuff/people is really funny. And you know where funny stuff fits well? The wizard kit. OH YEAH and being shrunken now gives you the squash component so you can be squashed as though you were a roach, though this only deals 10 damage instead of gibbing you tiny staff  tiny wand  exhausted wand turns back to a big wand sprite :)  ## Why It's Good For The Game Shrinking stuff is funny, plus it gives the wizard something new to do besides polymorphing everyone or turning everybody to stone or ei nathing people. ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: add: New funny wizard staff/wand that shrinks stuff. add: Being shrunken now leaves you vulnerable to being crushed to death. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Staff of Shrinking for the wizard --------- Co-authored-by: PKPenguin321 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 16, 2024
* Staff of Shrinking for the wizard (#83115) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds a new staff for the wizard that shoots shrink rays. Also a corresponding wand that comes with the wand belt. Shrinking is a mechanic already implemented by abductors, but it's not often used because it doesn't fit their kit super well. That's a huge shame because shrinking stuff/people is really funny. And you know where funny stuff fits well? The wizard kit. OH YEAH and being shrunken now gives you the squash component so you can be squashed as though you were a roach, though this only deals 10 damage instead of gibbing you tiny staff  tiny wand  exhausted wand turns back to a big wand sprite :)  ## Why It's Good For The Game Shrinking stuff is funny, plus it gives the wizard something new to do besides polymorphing everyone or turning everybody to stone or ei nathing people. ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: add: New funny wizard staff/wand that shrinks stuff. add: Being shrunken now leaves you vulnerable to being crushed to death. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Staff of Shrinking for the wizard --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: PKPenguin321 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1524
Original PR: tgstation/tgstation#82075
About The Pull Request
This changes the action_types on the face scarf from being a static datum to being a list. This is a bug I noticed while working on a PR downstream where i was attempting to add an action to a set of items and this caused a miss-matched type CI error. This realistically shouldn't be the case as everything else on the code base that uses action_types is also a list. So for consistency sake and to remove bugs this will fix the var to be a list instead of static.
Why It's Good For The Game
Less bugs, more consistency with variables.
Changelog
I don't really think this needs a change log, not really player noticeable or player facing. The relative impact on players is minor